Skip to content

Bug 1860229: Fail machine if create request doesn't succeed #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 8, 2020
Merged

Bug 1860229: Fail machine if create request doesn't succeed #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/cloud/azure/actuators/machine/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (

"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2019-12-01/compute"
"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2019-12-01/network"
"github.com/Azure/go-autorest/autorest"
"github.com/Azure/go-autorest/autorest/to"
machinev1 "github.com/openshift/machine-api-operator/pkg/apis/machine/v1beta1"
machinecontroller "github.com/openshift/machine-api-operator/pkg/controller/machine"
Expand Down Expand Up @@ -607,6 +608,11 @@ func (s *Reconciler) createVirtualMachine(ctx context.Context, nicName string) e
Namespace: s.scope.Machine.Namespace,
Reason: err.Error(),
})

var detailedError autorest.DetailedError
if errors.As(err, &detailedError) && detailedError.Message == "Failure sending request" {
return machinecontroller.InvalidMachineConfiguration("failure sending request for machine %s", s.scope.Machine.Name)
}
Comment on lines +612 to +615
Copy link

@JoelSpeed JoelSpeed Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to see the actual error logged anywhere when this happens?

Copy link
Author

@alexander-demicev alexander-demicev Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error will be returned by reconciler's Create(), I'd expect the machine controller to log it somewhere.

Copy link

@JoelSpeed JoelSpeed Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, wonder if there's any more information than Failure sending request that we could extract to improve the UX?

return fmt.Errorf("failed to create or get machine: %w", err)
}
} else if err != nil {
Expand Down