Bug 1860229: Fail machine if create request doesn't succeed#155
Bug 1860229: Fail machine if create request doesn't succeed#155openshift-merge-robot merged 1 commit intoopenshift:masterfrom alexander-demicev:errors
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@alexander-demichev: This pull request references Bugzilla bug 1860229, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| var detailedError autorest.DetailedError | ||
| if errors.As(err, &detailedError) && detailedError.Message == "Failure sending request" { | ||
| return machinecontroller.InvalidMachineConfiguration("failure sending request for machine %s", s.scope.Machine.Name) | ||
| } |
There was a problem hiding this comment.
Are we going to see the actual error logged anywhere when this happens?
There was a problem hiding this comment.
This error will be returned by reconciler's Create(), I'd expect the machine controller to log it somewhere.
There was a problem hiding this comment.
Ok, wonder if there's any more information than Failure sending request that we could extract to improve the UX?
JoelSpeed
left a comment
JoelSpeed
left a comment
There was a problem hiding this comment.
Might be good to improve the logging if at all possible, non-blocking though
/approve
| var detailedError autorest.DetailedError | ||
| if errors.As(err, &detailedError) && detailedError.Message == "Failure sending request" { | ||
| return machinecontroller.InvalidMachineConfiguration("failure sending request for machine %s", s.scope.Machine.Name) | ||
| } |
There was a problem hiding this comment.
Ok, wonder if there's any more information than Failure sending request that we could extract to improve the UX?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexander-demichev: All pull requests linked via external trackers have merged: Bugzilla bug 1860229 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Fail machine if create request doesn't succeed.
For spot instances when the max price is lower than the current spot price, we should fail the machine. Currently, we are constantly trying to provision it. Azure error types are not great, so I think this is the cleanest way to fail machines.
This approach will also fail the machines in other cases like reaching quota limits.