Load Balancer update #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
csrwng
force-pushed
the
elb_update
branch
2 times, most recently
from
0ee4af6 to
ad560c4
Compare
openshift-ci-robot
added
size/M
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Author
|
@ingvagabund ptal |
Changes the type/name of the LoadBalancers field in ProviderConfig. AWS only allows identifying load balancers by name, and their Describe call doesn't allow Filters.
Member
|
@spangenberg good candidate for another e2e test. Something like:
Could be even done as part of the |
enxebre
reviewed
Oct 24, 2018
|
|
||
| } | ||
|
|
||
| err = a.UpdateLoadBalancers(client, machineProviderConfig, newestInstance, mLog) |
Member
|
/lgtm |
ingvagabund
reviewed
Oct 24, 2018
| Instances: []*elb.Instance{elbInstance}, | ||
| LoadBalancerName: aws.String(elbName), | ||
| } | ||
| _, err := client.RegisterInstancesWithLoadBalancer(req) |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Author
|
looks like the router test is not finding what it expects: /retest |
vikaschoudhary16
pushed a commit
to vikaschoudhary16/cluster-api-provider-aws
that referenced
this pull request
Jan 16, 2019
Signed-off-by: Vince Prignano <[email protected]> add comments Signed-off-by: Vince Prignano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the capability of adding machines to specified Load Balancers as they are created or updated.
The LoadBalancer field in ProviderConfig is renamed from LoadBalancerIDs to LoadBalancerNames and its type set to string. AWS only allows specifying load balancers by name, and their describe call doesn't allow Filters.
Depends on #81