Merged
Conversation
… might not be enable
Migrate to CRDs - WIP
enxebre
added
the
do-not-merge/hold
openshift-ci-robot
added
the
size/XXL
Member
|
/test e2e |
Merged
Member
Author
|
/test all |
Member
Author
|
/test e2e-aws |
Member
Author
|
e2e-aws will fail until openshift/machine-api-operator#100 gets part of the pr payload |
Member
Author
|
/test e2e-aws |
4 similar comments
Member
Author
|
/test e2e-aws |
Member
Author
|
/test e2e-aws |
Member
Author
|
/test e2e-aws |
Member
Author
|
/test e2e-aws |
enxebre
removed
the
do-not-merge/hold
Member
Author
|
/test e2e-aws |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
|
/test images |
This was referenced Oct 24, 2018
vikaschoudhary16
pushed a commit
to vikaschoudhary16/cluster-api-provider-aws
that referenced
this pull request
Jan 16, 2019
When there is at least 1 private subnet defined, ReoncileNatGateways will create a NAT gateway for every public subnet. We assume that subnets will be created in pairs for each availability zone intially. Signed-off-by: Naadir Jeewa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support or CRDS
Image is
registry.svc.ci.openshift.org/openshift/aws-machine-controllers:crd