-
Notifications
You must be signed in to change notification settings - Fork 50
Use openshift/origin-base as an image base #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
please use the following see cluster monitoring operator as an example: |
|
@derekwaynecarr thanks for chiming in 👍 This is a temporary solution for testing purposes only and it basically reverts kubernetes-sigs/cluster-api#213. Right now we need any image which can be used in CI to build images and later we can dive into details. There was a discussion in slack channel #forum-testinfra about various base images, how exactly In the end if we want to maintain our implementation of cluster-api-provider-aws, then we can use |
|
Would be great to run it through the CI first. Otherwise, I don't see anything wrong about it right now. |
|
/test all |
|
/refresh |
|
/retest |
|
/assign @ingvagabund @enxebre |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This uses alpine as a base image to get started with CI pipeline
/wip