Skip to content

Conversation

@paulfantom
Copy link

This uses alpine as a base image to get started with CI pipeline

/wip

@paulfantom paulfantom added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2018
@derekwaynecarr
Copy link
Member

please use the following FROM openshift/origin-base.

see cluster monitoring operator as an example:
https://github.com/openshift/cluster-monitoring-operator/blob/master/Dockerfile#L1

@paulfantom
Copy link
Author

@derekwaynecarr thanks for chiming in 👍

This is a temporary solution for testing purposes only and it basically reverts kubernetes-sigs/cluster-api#213. Right now we need any image which can be used in CI to build images and later we can dive into details.

There was a discussion in slack channel #forum-testinfra about various base images, how exactly FROM is working in ci-operator/prow, and if it is possible to use something different than openshift/origin-v3.11 (example) image. It was inconclusive hence this PR.

In the end if we want to maintain our implementation of cluster-api-provider-aws, then we can use openshift/origin-base, but if we want to use upstream images, it might be good to have similar build process to upstream one.

@paulfantom paulfantom removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2018
@ingvagabund
Copy link
Member

Would be great to run it through the CI first. Otherwise, I don't see anything wrong about it right now.

@paulfantom
Copy link
Author

/test all

@paulfantom paulfantom changed the title Use alpine as an image base Use openshift/origin-base as an image base Aug 23, 2018
@smarterclayton
Copy link

/refresh

@paulfantom
Copy link
Author

/retest

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2018
@paulfantom
Copy link
Author

/assign @ingvagabund @enxebre

@ingvagabund
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,paulfantom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a4dda2e into master Aug 24, 2018
@frobware
Copy link

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants