Skip to content

TRT-2536: UPSTREAM: <carry>: Fix OTE list tests when SingleReplica #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 4, 2026
Merged

TRT-2536: UPSTREAM: <carry>: Fix OTE list tests when SingleReplica #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion tests/aws-cloud-controller-manager-tests-ext/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,24 @@ func main() {
if err != nil {
panic(fmt.Errorf("failed to select specs: %w", err))
}

// Skip set of tests when topology is SingleReplica.
singleReplicaSkips := []string{
"nodes should label nodes with topology network info if instance is supported",
"nodes should set zone-id topology label",
}

// Add the suite name to the spec name and apply topology-based exclusions.
specs.Walk(func(spec *extensiontests.ExtensionTestSpec) {
spec.Name = spec.Name + " [Suite:openshift/conformance/parallel]"

// Exclude specific tests when topology is SingleReplica.
for _, skip := range singleReplicaSkips {
if strings.Contains(spec.Name, skip) {
spec.Exclude(extensiontests.TopologyEquals("SingleReplica"))
}
}

}).Include(extensiontests.PlatformEquals("aws"))
specs.AddBeforeAll(func() {
if err := initFrameworkForTest(); err != nil {
Expand All @@ -72,7 +88,7 @@ func main() {
registry.Register(ext)

root := &cobra.Command{
Long: "Machine API Operator tests extension for OpenShift",
Long: "AWS Cloud Controller Manager tests extension for OpenShift",
}
root.AddCommand(cmd.DefaultExtensionCommands(registry)...)
if err := func() error {
Expand Down