TRT-2536: UPSTREAM: <carry>: Fix OTE list tests when SingleReplica by mtulio · Pull Request #125 · openshift/cloud-provider-aws

mtulio · 2026-02-03T14:57:09Z

OTE proposal to fix node tests failures by skipping those when SingleReplica topology, those requires the minimum nodes more than that topology is using on CI.

https://issues.redhat.com/browse/TRT-2536
https://redhat-internal.slack.com/archives/C01CQA76KMX/p1769959838314579

Force skip node tests when SingleReplica topology as it requires the minimum nodes more than that topology is using on CI. https://issues.redhat.com/browse/TRT-2536 https://redhat-internal.slack.com/archives/C01CQA76KMX/p1769959838314579

openshift-ci-robot · 2026-02-03T14:57:28Z

@mtulio: This pull request references TRT-2536 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Force skip node tests when SingleReplica topology as it requires the minimum nodes more than that topology is using on CI.

https://issues.redhat.com/browse/TRT-2536
https://redhat-internal.slack.com/archives/C01CQA76KMX/p1769959838314579

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-03T14:57:43Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

mtulio · 2026-02-03T15:00:26Z

/test ?

openshift-ci · 2026-02-03T15:37:38Z

@mtulio: This PR was included in a payload test run from openshift/origin#30747
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1ffc4210-0116-11f1-9819-cd56774c6083-0

mtulio · 2026-02-03T16:48:10Z

Testing locally shows exclusions:

$ ./aws-cloud-controller-manager-tests-ext list | jq .[].name
"[cloud-provider-aws-e2e] loadbalancer CLB should be reachable with default configurations [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer NLB should be reachable with default configurations [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer CLB internal should be reachable with hairpinning traffic [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] nodes should set zone-id topology label [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] nodes should label nodes with topology network info if instance is supported [Suite:openshift/conformance/parallel]"

$ ./aws-cloud-controller-manager-tests-ext list --topology=SingleReplica --platform=aws | jq .[].name
"[cloud-provider-aws-e2e] loadbalancer CLB should be reachable with default configurations [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer NLB should be reachable with default configurations [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer CLB internal should be reachable with hairpinning traffic [Suite:openshift/conformance/parallel]"
"[cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic [Suite:openshift/conformance/parallel]"

Cross-ref tests are failing caused by CI build (openshift/origin#30747 (comment) https://github.com/openshift/origin/pull/30747/checks?check_run_id=62361908066), and there is not presubmit for SNO here, I will trigger regular jobs for readiness.

openshift-ci-robot · 2026-02-03T16:49:19Z

@mtulio: This pull request references TRT-2536 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

OTE proposal to fix node tests failures by skipping those when SingleReplica topology, those requires the minimum nodes more than that topology is using on CI.

https://issues.redhat.com/browse/TRT-2536
https://redhat-internal.slack.com/archives/C01CQA76KMX/p1769959838314579

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mtulio · 2026-02-03T17:29:54Z

/test images

nrb · 2026-02-03T21:14:00Z

/test images

nrb · 2026-02-03T21:14:39Z

/lgtm

assuming CI starts passing

mtulio · 2026-02-03T21:31:18Z

WRT CI failures: we are investigating on slack and weather this PR could resolve the rhcos builds: openshift/release#74332

mtulio · 2026-02-03T21:33:53Z

Slack thread to follow up: https://redhat.enterprise.slack.com/archives/C01CQA76KMX/p1770142263269789?thread_ts=1769959838.314579&channel=C01CQA76KMX&message_ts=1770142263.269789

I will keep here updated as soon I have news

openshift-ci · 2026-02-03T22:26:53Z

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade	`7290da1`	link	true	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-hypershift	`7290da1`	link	true	`/test e2e-hypershift`
ci/prow/images	`7290da1`	link	true	`/test images`
ci/prow/e2e-aws-ovn	`7290da1`	link	true	`/test e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mtulio · 2026-02-04T13:33:15Z

Converting to draft til we have green signals of CI infra issue
fic(o/cloud-provider-*): add rhel-coreos input release#74366 proposes to fix the RHCOS image build
waiting for CI signal

/test images

openshift-ci · 2026-02-04T13:34:57Z

@mtulio: This PR was included in a payload test run from openshift/origin#30747
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/44e2a1b0-01ce-11f1-9724-30c89ce3097e-0

mtulio · 2026-02-04T14:01:19Z

images is now passing, converting to regular PR to trigger overall tests while cross PR is running with OTE (last comment)

mtulio · 2026-02-04T14:01:24Z

/retest-required

mtulio · 2026-02-04T17:09:57Z

@mtulio: This PR was included in a payload test run from openshift/origin#30747 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/44e2a1b0-01ce-11f1-9724-30c89ce3097e-0

I am observing in the live logs of running payload job that the OTE is now listing only expected test counts (5):

time="2026-02-04T15:02:27Z" level=info msg="Listed 5 tests in 64.69073ms" binary=aws-cloud-controller-manager-tests-ext

Similar what I've observed in local tests.

This PR is generally ready for review so then we can unblock the binary extraction.

/assign @nrb @neisw

mtulio · 2026-02-04T17:10:35Z

/verified by #125 (comment)

openshift-ci-robot · 2026-02-04T17:10:48Z

@mtulio: This PR has been marked as verified by https://github.com/openshift/cloud-provider-aws/pull/125#issuecomment-3848683374.

Details

In response to this:

/verified by #125 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-04T17:37:53Z

@mtulio: This PR was included in a payload test run from openshift/origin#30747
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-02-04T17:39:06Z

@mtulio: This PR was included in a payload test run from openshift/origin#30747
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/65449bd0-01f0-11f1-84ad-012a5909521e-0

mtulio · 2026-02-04T19:31:01Z

SNO job is reporting passing on five tests prefixed with [cloud-provider-aws] exposed by OTE.

elmiko · 2026-02-04T20:06:17Z

/approve

openshift-ci · 2026-02-04T20:06:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Re-add OTE binary extraction for CCM-AWS after skips added to the binary[1], and successful jobs taken to SNO[2]. [1] openshift/cloud-provider-aws#125 [2] https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-cloud-provider-aws-125-openshift-origin-30747-ci-4.22-e2e-aws-upgrade-ovn-single-node/2019041978443894784

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2026

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2026

mtulio mentioned this pull request Feb 3, 2026

SPLAT-2337: CCM-AWS OTE binary and skips openshift/origin#30747

Merged

mtulio marked this pull request as ready for review February 3, 2026 16:49

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2026

openshift-ci bot requested review from RadekManak and nrb February 3, 2026 16:49

openshift-ci bot assigned nrb Feb 3, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026

mtulio marked this pull request as draft February 4, 2026 13:32

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026

mtulio marked this pull request as ready for review February 4, 2026 14:01

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026

openshift-ci bot requested review from damdo and racheljpg February 4, 2026 14:02

openshift-ci bot assigned neisw Feb 4, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 4, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026

openshift-merge-bot bot merged commit abb165b into openshift:main Feb 4, 2026
8 checks passed

mtulio deleted the fix-ote branch February 4, 2026 20:13

Conversation

mtulio commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 3, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 3, 2026

Uh oh!

mtulio commented Feb 3, 2026

Uh oh!

openshift-ci bot commented Feb 3, 2026

Uh oh!

mtulio commented Feb 3, 2026

Uh oh!

openshift-ci-robot commented Feb 3, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtulio commented Feb 3, 2026

Uh oh!

nrb commented Feb 3, 2026

Uh oh!

nrb commented Feb 3, 2026

Uh oh!

mtulio commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtulio commented Feb 3, 2026

Uh oh!

openshift-ci bot commented Feb 3, 2026

Uh oh!

mtulio commented Feb 4, 2026

Uh oh!

openshift-ci bot commented Feb 4, 2026

Uh oh!

mtulio commented Feb 4, 2026

Uh oh!

mtulio commented Feb 4, 2026

Uh oh!

mtulio commented Feb 4, 2026

Uh oh!

mtulio commented Feb 4, 2026

Uh oh!

openshift-ci-robot commented Feb 4, 2026

Uh oh!

openshift-ci bot commented Feb 4, 2026

Uh oh!

openshift-ci bot commented Feb 4, 2026

Uh oh!

mtulio commented Feb 4, 2026

Uh oh!

elmiko commented Feb 4, 2026

Uh oh!

openshift-ci bot commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mtulio commented Feb 3, 2026 •

edited

Loading

openshift-ci-robot commented Feb 3, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 3, 2026 •

edited by openshift-ci bot

Loading

mtulio commented Feb 3, 2026 •

edited

Loading