Skip to content

DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG for NLB#107

Closed
mtulio wants to merge 13 commits intoopenshift:mainfrom
mtulio:SPLAT-2113
Closed

DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG for NLB#107
mtulio wants to merge 13 commits intoopenshift:mainfrom
mtulio:SPLAT-2113

Conversation

@mtulio
Copy link
Copy Markdown

@mtulio mtulio commented Apr 23, 2025

DNM - PR spike used to build images with cluster bot as local build isn't working as expected.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 23, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

DNM - PR spike used to build images with cluster bot as local build isn't working as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio changed the title DNM: SPLAT-2113: spike NLB with SGs when annotation is present DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG Apr 28, 2025
@mtulio mtulio changed the title DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG for NLB Apr 28, 2025
@mtulio mtulio force-pushed the SPLAT-2113 branch 8 times, most recently from 553c27d to 6ed5ae5 Compare May 5, 2025 19:12
Introduce support of NLB provisioning with Security Groups when the
following annotation matches:

- service.beta.kubernetes.io/aws-load-balancer-manage-security-group: managed SG (CCM creates Security Group):
- service.beta.kubernetes.io/aws-load-balancer-security-groups and
  service.beta.kubernetes.io/aws-load-balancer-extra-security-groups:
unmanaged Security Group (CCM will not create or manage rules)
@mtulio
Copy link
Copy Markdown
Author

mtulio commented Jun 11, 2025

Closing PR in favor of upstream change. See the original task for more details: https://issues.redhat.com/browse/SPLAT-2253

@mtulio mtulio closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants