DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG for NLB#107
DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup support BYO SG for NLB#107mtulio wants to merge 13 commits intoopenshift:mainfrom
Conversation
|
@mtulio: This pull request references SPLAT-2113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
553c27d to
6ed5ae5
Compare
Introduce support of NLB provisioning with Security Groups when the following annotation matches: - service.beta.kubernetes.io/aws-load-balancer-manage-security-group: managed SG (CCM creates Security Group): - service.beta.kubernetes.io/aws-load-balancer-security-groups and service.beta.kubernetes.io/aws-load-balancer-extra-security-groups: unmanaged Security Group (CCM will not create or manage rules)
|
Closing PR in favor of upstream change. See the original task for more details: https://issues.redhat.com/browse/SPLAT-2253 |
DNM - PR spike used to build images with cluster bot as local build isn't working as expected.