Skip to content

DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup feature gate#2299

Closed
mtulio wants to merge 1 commit intoopenshift:masterfrom
mtulio:SPLAT-2113
Closed

DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup feature gate#2299
mtulio wants to merge 1 commit intoopenshift:masterfrom
mtulio:SPLAT-2113

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 28, 2025

Hello @mtulio! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 28, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio changed the title DNM/SPLAT-2113: spike added IngressNLBSecurityGroup feature gate DNM/SPLAT-2113: spike aws/CIO/IngressNLBSecurityGroup feature gate Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio force-pushed the SPLAT-2113 branch 3 times, most recently from 9254b3a to bc9cb90 Compare May 3, 2025 03:14
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 15, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-1of2 bc9cb90 link true /test e2e-aws-serial-1of2
ci/prow/e2e-aws-serial-techpreview-1of2 bc9cb90 link true /test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-serial-techpreview-2of2 bc9cb90 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-2of2 bc9cb90 link true /test e2e-aws-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Jun 11, 2025

Closing as Won't Do as the approach will be changing the CCM to support SG when Service type-LoadBalancer NLB when cloud-config is enabled (enforced by CCCMO).

No CIO changes will be required using that approach.

See SPLAT-2253 and enhancement SPLAT-2187 for more details.

@mtulio mtulio closed this Jun 11, 2025
@mtulio mtulio deleted the SPLAT-2113 branch June 11, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants