*: use a global codec #576
Conversation
|
Depends on #575 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 47.66% 47.86% +0.19%
==========================================
Files 94 94
Lines 11696 11617 -79
==========================================
- Hits 5575 5560 -15
+ Misses 5494 5444 -50
+ Partials 627 613 -14
|
Signed-off-by: Steve Kuznetsov <[email protected]>
The codec *is* global and only ever changes at compile-time, so generally the pattern is to declare it as a package global and intiialize it in an init() method. 30% of our runtime allocations were building up the scheme/codec on-demand. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/pprof
branch
from
dda3fad to
7a9354b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
*: use a global codec
3 participants
pkg/operator: correctly fetch CA for AWS minter
We just need to read one and only one ConfigMap, so add a Role to
let us and use a live client to just read the thing.
Signed-off-by: Steve Kuznetsov [email protected]
cmd: add pprof endpoint
Signed-off-by: Steve Kuznetsov [email protected]
*: use a global codec
The codec is global and only ever changes at compile-time, so
generally the pattern is to declare it as a package global and
intiialize it in an init() method. 30% of our runtime allocations were
building up the scheme/codec on-demand.
Signed-off-by: Steve Kuznetsov [email protected]