Skip to content

Conversation

@shirady
Copy link
Contributor

@shirady shirady commented Oct 11, 2023

Explain the changes

  1. Update package cloud-credential-operator, by running: go get -u github.com/openshift/cloud-credential-operator, the output is:
go: downloading github.com/openshift/cloud-credential-operator v0.0.0-20231004191224-abdf0627a0cf
go: upgraded github.com/asaskevich/govalidator v0.0.0-20200907205600-7a23bdc65eef => v0.0.0-20210307081110-f21760c49a8d
go: upgraded github.com/openshift/cloud-credential-operator v0.0.0-20210716145643-0ee1808fb8ed => v0.0.0-20231004191224-abdf0627a0cf
go: upgraded k8s.io/kube-aggregator v0.19.0 => v0.27.1
  1. Changes in code related to the update of the package of the cloud credential operator.
    change NewCodec() to Codec since it was removed and we should use global codec (for more information see PR *: use a global codec openshift/cloud-credential-operator#576.

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

  1. Run make all.
    Note: before the code change we had 2 errors (same error message):
undefined: cloudcredsv1.NewCodec
  1. Use the cluster bot using launch 4.14 aws, then noobaa install should be Ready and we should have default backingstore type will be aws-s3.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Oct 11, 2023
@shirady
Copy link
Contributor Author

shirady commented Oct 11, 2023

Detailed Testing Instructions:

Image:

  1. I have MacOS, for using the cluster-bot I need the operator image for linux/amd64 (when I run make all it builds it for arm64), hence for building the image I run: DOCKER_DEFAULT_PLATFORM=linux/amd64 GOARCH=amd64 make all.
  2. Then tag it to my Quay account and push the image:
    docker tag noobaa/noobaa-operator:5.15.0 quay.io/<my-user>/noobaa-operator:<my-tag>
    docker push quay.io/<my-user>/noobaa-operator:<my-tag>

Install noobaa:

After I set the cluster with the configuration I've got from the cluster bot and I'm on the operator repo in my terminal I run:
. ./devenv.sh
Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).
nb install --dev --noobaa-image='<noobaa-image-from-docker-hub>' --operator-image='quay.io/<my-user>/noobaa-operator:<my-tag>' -n <my-namespace>

Check logs of the operator:

kubectl logs noobaa-operator-<rest-of-the-numbers-in-the-name> -n <my-namespace>
Inside the logs of the operator we should have the printing:
"Secret noobaa-aws-cloud-creds-secret was created successfully by cloud-credentials operator."

Check the default backingstore type:

kubectl get backingstore -n <my-namespace>
output:

NAME                           TYPE     PHASE   AGE
noobaa-default-backing-store   aws-s3   Ready   68s

@shirady shirady force-pushed the update-package-cloud-credential branch from e8a0cfa to 7f866a8 Compare October 11, 2023 14:48
1. update package cloud-credential-operator
2. changes in code related to the update of the package of cloud credential operator -
   change NewCodec() to Codec since it was removed and we should use global codec

Signed-off-by: shirady <[email protected]>
@shirady shirady force-pushed the update-package-cloud-credential branch from 7f866a8 to bec9853 Compare October 16, 2023 10:48
@shirady shirady merged commit 6a9090e into noobaa:master Oct 16, 2023
@shirady shirady deleted the update-package-cloud-credential branch October 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants