CCO-394: Do not Add PodIdentityWebhook controller when InfraStatus.ControlPlaneToplogy is External.

[abutcher]

Do not deploy the pod identity webhook when infrastructure ControlPlaneTopology is External since Hypershift deploys the webhook independently.

[abutcher]

/hold

[abutcher]

Double checked that the platform type is "AWS" on a hypershift clusterbot cluster to ensure this is necessary. The check prior to change in the existing Add() bases deployment of the controller on the platform type being "AWS".

oc get infrastructure cluster -o jsonpath --template '{ .status.platform }'
AWS

[codecov]

Codecov Report

Merging #547 (b591f47) into master (f9a6219) will increase coverage by 2.04%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   48.78%   50.82%   +2.04%     
==========================================
  Files          88       93       +5     
  Lines        9858    12857    +2999     
==========================================
+ Hits         4809     6535    +1726     
- Misses       4474     5655    +1181     
- Partials      575      667      +92     

Impacted Files	Coverage Δ
...awspodidentity/awspodidentitywebhook_controller.go	36.06% <0.00%> (+3.63%)	⬆️

... and 22 files with indirect coverage changes

[abutcher]

/unhold

[gallettilance]

@abutcher I create CCO-394 to track this work if you want to add it to the title of the PR to have it all linked up

[openshift-ci-robot]

@abutcher: This pull request references CCO-394 which is a valid jira issue.

Details

In response to this:

Do not deploy the pod identity webhook when infrastructure ControlPlaneTopology is External since Hypershift deploys the webhook independently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abutcher]

Thanks @gallettilance! Done!
/assign @jstuever
/cc @stevekuznetsov

[jstuever]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abutcher,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.