Skip to content

Conversation

@yannickstruyf3
Copy link

Adding the Nutanix Platform to the cloud-credential-operator. Supported mode is passthrough.

PR still WIP since openshift/api PR containing Nutanix platform is not yet merged to master.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yannickstruyf3
To complete the pull request process, please assign akhil-rane after the PR has been reviewed.
You can assign the PR to them by writing /assign @akhil-rane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

@yannickstruyf3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws e7220c4 link true /test e2e-aws
ci/prow/coverage e7220c4 link true /test coverage
ci/prow/unit e7220c4 link true /test unit
ci/prow/images e7220c4 link true /test images
ci/prow/verify e7220c4 link true /test verify
ci/prow/e2e-upgrade e7220c4 link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelddiaz
Copy link
Contributor

I haven't looked at the code, but just looking at the list of files added/modified I suspect someone has steered you in the wrong direction...

For new platforms, we are not adding in-cluster operator handling of platform credentials. The "new" thing to do is to run the cloud-cred-operator in "Manual" mode, and have some external tooling (this repo has ccoctl for that purpose) to do the pre-installation/pre-upgrade credentials management.
See the IBMCloud and Alibaba cloud PRs for examples of the "new way".
#412
#356

The docs probably need some updating, but it does talk about supporting "Manual" mode at a minimum and Mint/Passthrough as optional: https://github.com/openshift/cloud-credential-operator/blob/master/docs/adding-new-cloud-provider.md

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2021

@yannickstruyf3: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2021
@thunderboltsid
Copy link
Contributor

@joelddiaz Can you take a look at #450 ?

@akhil-rane
Copy link
Contributor

We have a separate PR #450 for Nutanix support. Closing this PR.

@akhil-rane akhil-rane closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants