-
Notifications
You must be signed in to change notification settings - Fork 159
WIP: Nutanix platform passthrough #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Nutanix platform passthrough #432
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yannickstruyf3 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@yannickstruyf3: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I haven't looked at the code, but just looking at the list of files added/modified I suspect someone has steered you in the wrong direction... For new platforms, we are not adding in-cluster operator handling of platform credentials. The "new" thing to do is to run the cloud-cred-operator in "Manual" mode, and have some external tooling (this repo has The docs probably need some updating, but it does talk about supporting "Manual" mode at a minimum and Mint/Passthrough as optional: https://github.com/openshift/cloud-credential-operator/blob/master/docs/adding-new-cloud-provider.md |
|
@yannickstruyf3: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@joelddiaz Can you take a look at #450 ? |
|
We have a separate PR #450 for Nutanix support. Closing this PR. |
Adding the Nutanix Platform to the cloud-credential-operator. Supported mode is passthrough.
PR still WIP since openshift/api PR containing Nutanix platform is not yet merged to master.