Skip to content

Conversation

@dongchen126
Copy link

Support the Alibaba Cloud platform in manual mode
phase 1: Add 'AlibabaCloudProviderSpec' and 'AlibabaCloudProviderStatus'
phase 2: 'ccoctl' support(ongoing)

Support the Alibaba Cloud platform in manual mode
Add AlibabaCloudProviderSpec and AlibabaCloudProviderStatus

Signed-off-by: sunhui <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

Hi @dongchen126. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 3, 2021
@openshift-ci openshift-ci bot requested review from akhil-rane and suhanime November 3, 2021 11:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongchen126
To complete the pull request process, please assign suhanime after the PR has been reviewed.
You can assign the PR to them by writing /assign @suhanime in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


// ConditionKeyValue - mapping of values for the chosen type
// +k8s:deepcopy-gen=false
type ConditionKeyValue map[string]interface{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using type interface{} complicates generating deep-copy functions. See https://github.com/openshift/cloud-credential-operator/blob/master/pkg/apis/cloudcredential/v1/aws_manual.deepcopy.go and openshift/api#683 (review) .

Just because we made this mistake for the AWS cloud, does not mean we should repeat it for Alibaba Cloud. Please specify the exact values this field can hold, or just remove the ability to specify conditions as part of each Entry.

If we do in fact expect to have components specify static Conditions as part of their permissions lists, I'd like to see some examples.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review.
At present, Condition is not needed in Alibaba Cloud's credsRequest, so I removed it.

@dongchen126
Copy link
Author

Closed this PR due to will use new PR #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants