Skip to content

WIP: AzureStack support #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joelddiaz wants to merge 4 commits into from
Closed

WIP: AzureStack support #315

joelddiaz wants to merge 4 commits into from

Conversation

@joelddiaz
Copy link
Contributor

@joelddiaz joelddiaz commented Mar 26, 2021 •
edited by dgoodwin
Loading

  • update Azure dependencies (not strictly necessary)
  • vendor in updated openshift/api (for AzureStack constants)
  • Extend the Azure client setup to look into the openshift-config/cloud-provider-config configMap to detect when the cluster is running on AzureStack
  • Read in the endpoints JSON and set the appropriate environment variable before running throught he Azure SDK client configuration. (still waiting on what the actual ConfigMap will look like)

xref: https://issues.redhat.com/browse/CCO-102

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021
@joelddiaz
Copy link
Contributor Author

joelddiaz commented Mar 26, 2021

/hold
temporarily vendoring patrickdillon/api@azurestack until openshift/api#860 merges so we can then do a real vendor

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@joelddiaz joelddiaz force-pushed the azure-stack-hub branch 2 times, most recently from ec3c9bb to 4bef775 Compare March 26, 2021 19:48
@joelddiaz
Copy link
Contributor Author

joelddiaz commented Mar 29, 2021

/test e2e-azure

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2021
Joel Diaz added 4 commits April 7, 2021 11:19
update vendoring of Azure dependencies
1b5e930 
go get -u github.com/Azure/*
pull in unmerged openshift/api from patrickdillon/api@azurestack
28416c1 
so we can have the AzureStack string definitions

will need to update to actual openshift/api
update vendored CRDs and bindata
8c3d506
add support for AzureStack
c172952 
Extend the Azure client setup to look into the
openshift-config/cloud-provider-config configMap to detect when the
cluster is running on AzureStack.

Read in the endpoints JSON and set the appropriate environment variable
before running throught he Azure SDK client configuration.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2021

@joelddiaz: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor

dgoodwin commented Jun 3, 2021

Changed the x-ref to a card I made rather than the epic.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@joelddiaz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit c172952 link /test unit
ci/prow/e2e-upgrade c172952 link /test e2e-upgrade
ci/prow/e2e-aws c172952 link /test e2e-aws
ci/prow/verify c172952 link /test verify
ci/prow/verify-deps c172952 link /test verify-deps
ci/prow/images c172952 link /test images
ci/prow/coverage c172952 link /test coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link

patrickdillon commented Jul 12, 2021

API PR has merged

@joelddiaz
Copy link
Contributor Author

joelddiaz commented Jul 13, 2021

cc @akhil-rane ^ API PR merged message

@akhil-rane
Copy link
Contributor

akhil-rane commented Jul 14, 2021

cc @akhil-rane ^ API PR merged message

sounds good I will take a look

@patrickdillon
Copy link

patrickdillon commented Jul 21, 2021

It looks like you were able to work with the cloud provider config configmap, but in case you were not aware the work is captured here: openshift/installer#5042. Hoping to merge this today/ASAP.

@gregsheremeta
Copy link
Contributor

gregsheremeta commented Jul 23, 2021

/close

all new platforms use Manual mode. See openshift/enhancements#709

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

@gregsheremeta: Closed this PR.

Details

In response to this:

/close

all new platforms use Manual mode. See openshift/enhancements#709

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joelddiaz @openshift-ci-robot @dgoodwin @patrickdillon @akhil-rane @gregsheremeta