Skip to content

config: Azure Stack Hub support #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 16, 2021
Merged

config: Azure Stack Hub support #860

openshift-merge-robot merged 1 commit into from
Jun 16, 2021

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Mar 10, 2021 •
edited
Loading

Add Azure Stack Hub as a valid Azure cloud environment.

See openshift/enhancements#689

cc @staebler

@patrickdillon patrickdillon mentioned this pull request Mar 10, 2021
Merged
staebler
staebler reviewed Mar 16, 2021
View reviewed changes
@staebler
Copy link
Contributor

staebler commented Mar 16, 2021

/lgtm
/assign @smarterclayton

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@joelddiaz joelddiaz mentioned this pull request Mar 26, 2021
Closed
4 tasks
patrickdillon added a commit to patrickdillon/cluster-config-operator that referenced this pull request Apr 5, 2021
@patrickdillon
WIP Vendor Commit -- DO NOT MERGE
fa9b80f 
Tests from personal branch as this depends on
09019a62fcc130deb99d5a6d529909205c9d6f60 from openshift/api#860
@patrickdillon patrickdillon mentioned this pull request Apr 5, 2021
Closed
@deads2k
Copy link
Contributor

deads2k commented Apr 5, 2021

I'm ok adding this, but the enhancement should be agreed and merged before merging the API.

@staebler
Copy link
Contributor

staebler commented Apr 6, 2021

I'm ok adding this, but the enhancement should be agreed and merged before merging the API.

@deads2k The enhancement has merged.

patrickdillon added a commit to patrickdillon/cluster-config-operator that referenced this pull request Apr 14, 2021
@patrickdillon
WIP Vendor Commit -- DO NOT MERGE
1c83ce3 
Tests from personal branch as this depends on
09019a62fcc130deb99d5a6d529909205c9d6f60 from openshift/api#860
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Apr 20, 2021

@deads2k would you mind taking another look at this?

/assign @deads2k

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Apr 20, 2021

Lost the /lgtm rebasing. @staebler can you reapply?

@staebler
Copy link
Contributor

staebler commented Apr 23, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2021
@deads2k
Copy link
Contributor

deads2k commented Apr 26, 2021

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, patrickdillon, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2021
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jun 9, 2021

I have added a field for the ARM Endpoint in 6734eef This is redundant information that is already captured in the cloud provider config, but the infrastructure object may be a preferable place to discover the endpoints.

If this API field is approved, we will update the cloud config operator to monitor this field, and upon a change, update the cloud provider config.

@Danil-Grigorev Danil-Grigorev mentioned this pull request Jun 14, 2021
Merged
@patrickdillon
config: Azure Stack Hub support
0d1c2dc 
Add Azure Stack Hub as a valid Azure cloud environment.

config/infra: add Azure ARM Endpoint

Adds ARM Endpoint to the Azure infrastructure status. This endpoint
would be used with Azure Stack Hub for resource management and
endpoint discovery.
Danil-Grigorev
Danil-Grigorev approved these changes Jun 16, 2021
View reviewed changes
Copy link

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, deads2k, patrickdillon, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fb4df74 into openshift:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@eparis eparis Awaiting requested review from eparis

2 more reviewers

@staebler staebler staebler left review comments

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

@deads2k deads2k

@staebler staebler

@Danil-Grigorev Danil-Grigorev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@patrickdillon @staebler @deads2k @openshift-ci-robot @Danil-Grigorev @smarterclayton @openshift-merge-robot