Skip to content

Conversation

@DavidHurta
Copy link
Contributor

Update the github.com/openshift/api dependency and update the generated code.
This is done to generate the client for a new DevPreview operator/v1alpha1 API introduced in openshift/api#2044.

Steps:

```
$ go get github.com/openshift/api@master
$ go mod tidy
$ go mod vendor
$ go mod verify
```
Steps:

```
$ export GOFLAGS=-mod=vendor
$ make generate
```
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@DavidHurta
Copy link
Contributor Author

/test all

@DavidHurta DavidHurta changed the title WIP: Update API dependency and update generated code OTA-209: Update API dependency and update generated code Dec 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024

@DavidHurta: This pull request references OTA-209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Update the github.com/openshift/api dependency and update the generated code.
This is done to generate the client for a new DevPreview operator/v1alpha1 API introduced in openshift/api#2044.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta
Copy link
Contributor Author

/test all

@DavidHurta DavidHurta marked this pull request as ready for review December 16, 2024 19:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@DavidHurta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 35abaf5 into openshift:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants