Skip to content

OTA-1029: Add ClusterVersionOperator API #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 13, 2024
Merged

OTA-1029: Add ClusterVersionOperator API #2044

openshift-merge-bot merged 2 commits into from
Dec 13, 2024

Conversation

@DavidHurta
Copy link
Contributor

@DavidHurta DavidHurta commented Sep 26, 2024 •
edited
Loading

This pull request will introduce the ClusterVersionOperator API in the DevPreviewNoUpgrade feature set as described in the openshift/enhancements#1492 enhancement.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

Hello @Davoska! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2024
@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 54d0403 to a946b4d Compare September 26, 2024 15:39
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Sep 26, 2024

/test all

@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from a946b4d to 274009a Compare September 26, 2024 16:37
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Sep 26, 2024

/test all

@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 274009a to 548e39c Compare September 27, 2024 14:05
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Sep 27, 2024

/test all

@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 548e39c to 2b19cd8 Compare September 27, 2024 15:28
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Sep 27, 2024

/test all

@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 2b19cd8 to 3037334 Compare October 14, 2024 14:19
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 3037334 to 74100d8 Compare October 14, 2024 14:20
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Oct 14, 2024

/test all

@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch 2 times, most recently from 1390978 to f5a5283 Compare October 14, 2024 16:24
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Oct 14, 2024

/test all

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Oct 14, 2024

/test e2e-gcp

@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from f5a5283 to d49ea4e Compare December 3, 2024 20:57
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Dec 4, 2024

/test all

@DavidHurta DavidHurta changed the title WIP: Add ClusterVersionOperator API OTA-1029: Add ClusterVersionOperator API Dec 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2024 •
edited by openshift-ci bot
Loading

@DavidHurta: This pull request references OTA-1029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Dec 11, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 11, 2024
@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 9abc0a6 to 837caea Compare December 11, 2024 00:45
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Dec 11, 2024

/remove-label tide/merge-method-squash

You aren't supposed to use squash on payload contributing repositories like this. Please rebase and squash manually into atomic commits

@openshift-ci openshift-ci bot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 11, 2024
@DavidHurta DavidHurta force-pushed the cluster-version-operator-configuration branch from 837caea to 7e03052 Compare December 11, 2024 14:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Dec 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024

/retest-required

Remaining retests: 0 against base HEAD 1a7b90f and 2 for PR HEAD 7e03052 in total

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024

/retest-required

Remaining retests: 0 against base HEAD 1a7b90f and 2 for PR HEAD 7e03052 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2024

/retest-required

Remaining retests: 0 against base HEAD 1a7b90f and 2 for PR HEAD 7e03052 in total

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Dec 12, 2024

/retest-required

1 similar comment
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Dec 12, 2024

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2024

/retest-required

Remaining retests: 0 against base HEAD 1a7b90f and 2 for PR HEAD 7e03052 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024 •
edited
Loading

@DavidHurta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 7e03052 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

/retest-required

Remaining retests: 0 against base HEAD f5726c3 and 2 for PR HEAD 7e03052 in total

@openshift-merge-bot openshift-merge-bot bot merged commit c117e1e into openshift:master Dec 13, 2024
@openshift-bot
Copy link

openshift-bot commented Dec 13, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202412131335.p0.gc117e1e.assembly.stream.el9.
All builds following this will include this PR.

@DavidHurta DavidHurta mentioned this pull request Dec 16, 2024
Merged
@DavidHurta DavidHurta mentioned this pull request Jan 22, 2025
Merged
DavidHurta added a commit to DavidHurta/cluster-version-operator that referenced this pull request Feb 24, 2025
@DavidHurta
pkg: Add ClusterVersionOperatorConfiguration feature gate
13fd095 
Make the CVO aware of a new feature gate called
ClusterVersionOperatorConfiguration, which was introduced in [1].

[1]: openshift/api#2044
DavidHurta added a commit to DavidHurta/cluster-version-operator that referenced this pull request Feb 26, 2025
@DavidHurta
pkg: Add ClusterVersionOperatorConfiguration feature gate
af6e781 
Make the CVO aware of a new feature gate called
ClusterVersionOperatorConfiguration, which was introduced in [1].

[1]: openshift/api#2044
hongkailiu pushed a commit to hongkailiu/cluster-version-operator that referenced this pull request Apr 2, 2025
@DavidHurta @hongkailiu
pkg: Add ClusterVersionOperatorConfiguration feature gate
4383e84 
Make the CVO aware of a new feature gate called
ClusterVersionOperatorConfiguration, which was introduced in [1].

[1]: openshift/api#2044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DavidHurta @openshift-ci-robot @JoelSpeed @openshift-bot @openshift-merge-robot