*: bugfix and refactor prefix semantics #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
lucab
reviewed
Jan 11, 2019
Contributor
lucab
left a comment
lucab
left a comment
There was a problem hiding this comment.
Nice! I didn't know about actix-web .prefix().
I've left a few minor comments, looks fine in general.
steveej
force-pushed
the
fix-path-prefix
branch
from
ae5e7db to
65f2ccc
Compare
lucab
reviewed
Jan 11, 2019
The bugfix and semantic change is that the prefix keeps, and if necessary adds, a leading slash. This simplifies the logic of dealing with prefixes because it doesn't require special-casing for emtpy namespaces which was buggy before. Using actix-web's prefix method removes the need to specify the prefix for every new route.
steveej
force-pushed
the
fix-path-prefix
branch
from
65f2ccc to
50f28ec
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucab, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugfix and semantic change is that the prefix keeps, and if
necessary adds, a leading slash. This simplifies the logic of dealing
with prefixes because it doesn't require special-casing for emtpy
namespaces which was buggy before.
Using actix-web's prefix method removes the need to specify the prefix
for every new route.
Fixes up #38.