Skip to content

Conversation

@steveej
Copy link
Contributor

@steveej steveej commented Jan 8, 2019

This gives the option to prefix all paths with a given namespace.

Contributes to https://jira.coreos.com/browse/CORS-957.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2019
@steveej steveej force-pushed the route-prefix branch 2 times, most recently from cce7ba5 to 2ebe470 Compare January 9, 2019 12:01
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2019
@steveej
Copy link
Contributor Author

steveej commented Jan 9, 2019

All comments addressed @lucab, PTAL.

This gives the option to prefix all public paths with a given namespace.
@lucab
Copy link
Contributor

lucab commented Jan 10, 2019

/lgtm

@openshift-ci-robot
Copy link

@lucab: changing LGTM is restricted to assignees, and only openshift/cincinnati repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steveej
Copy link
Contributor Author

steveej commented Jan 10, 2019

/refresh

@lucab
Copy link
Contributor

lucab commented Jan 10, 2019

/lgtm

@openshift-ci-robot
Copy link

@lucab: changing LGTM is restricted to assignees, and only openshift/cincinnati repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucab
Copy link
Contributor

lucab commented Jan 10, 2019

/refresh

@lucab
Copy link
Contributor

lucab commented Jan 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucab, steveeJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c959a0b into openshift:master Jan 10, 2019
@lucab
Copy link
Contributor

lucab commented Jan 10, 2019

(for reference, my previous reviews were rejected due to the same permission mismatch as openshift/installer#588 (comment))

@steveej steveej deleted the route-prefix branch January 10, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants