-
Notifications
You must be signed in to change notification settings - Fork 32
operator-sdk: upgrade to v1.2.0 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator-sdk: upgrade to v1.2.0 #87
Conversation
Pickup fix operator-framework/operator-sdk#4137 by upgrading from v1.0.0 to v1.2.0 by following: https://v1-1-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.1.0/ https://v1-2-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.2.0/
|
/lgtm Subsequent work on bundling and the Makefile will actually consume the new SDK. For now, we're just recommending maintainers run the SDK commands locally, so the README bump is the main thing here. |
LalatenduMohanty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, LalatenduMohanty The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding information why 4.3.2 and 4.3.3 is not in fast,stable 4.3
This was originally from b1465b7 (Information on why 4.3.2 and 4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87), but upon further review it is not severe enough to warrant blocked edges or promotions [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1805444#c9
This was originally from b1465b7 (Information on why 4.3.2 and 4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87), but upon further review it is not a regression and so does not warrant blocked edges or promotions [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1808429#c6
Expanding on the link from b1465b7 (Information on why 4.3.2 and 4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87). Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels, 2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates, since those are the only transitions where manifests dropped container ports [1]. Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug. 4.2 -> 4.3.1 had been blocked before, although that block was lifted in c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to fast-4.3), 2020-02-19, openshift#60). I think 1161d00's broader .* blocks (which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were because the Multus bug affects all updates, but, as explained in a5f394d (blocked-edges/4.3.*: Drop references to Multus bug 1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update blocker. Also, no need to talk about these in the channel YAML files, since we aren't tombstoning the releases (we discovered the bug after marking the releases supported by tagging them into fast channels). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
Pickup fix
operator-framework/operator-sdk#4137 by upgrading
from v1.0.0 to v1.2.0 by following:
https://v1-1-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.1.0/
https://v1-2-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.2.0/