Skip to content

Conversation

@LalatenduMohanty
Copy link
Member

Else go test was giving success everytime even if the test cluster was
deleted as the result was cached

$ go test -v ./functests/...
=== RUN TestCustomResource
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
--- PASS: TestCustomResource (241.87s)
PASS
ok github.com/openshift/cincinnati-operator/functests (cached)

Else go test was giving success everytime even if the test cluster was
deleted as the result was cached

$ go test -v ./functests/...
=== RUN   TestCustomResource
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
--- PASS: TestCustomResource (241.87s)
PASS
ok  	github.com/openshift/cincinnati-operator/functests	(cached)
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
Copy link

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 359ba0d into openshift:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants