OTA-1007: Include bundle manifests and Dockerfile #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just ran an existing `Makefile` target /shrug: ```console $ make bundle VERSION=5.0.2-dev cd config/manager && /usr/bin/kustomize edit set image controller=controller:latest /usr/bin/kustomize build config/manifests | operator-sdk generate bundle -q --overwrite --version 5.0.1 --channels=v1 --default-channel=v1 INFO[0000] Creating bundle.Dockerfile INFO[0000] Creating bundle/metadata/annotations.yaml INFO[0000] Bundle metadata generated successfully operator-sdk bundle validate ./bundle INFO[0000] All validation tests have completed successfully ```
openshift-ci
bot
added
the
approved
Contributor
|
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, PratikMahajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
petr-muller
changed the title
wking
added a commit
to wking/cincinnati-operator
that referenced
this pull request
Nov 22, 2023
Generated with: $ cp config/crd/bases/updateservice.operator.openshift.io_updateservices.yaml bundle/manifests/updateservice.operator.openshift.io_updateservices.yaml to catch up with 6b266d2 (config: Regenerate UpdateService CRD, 2023-10-03, openshift#176). 24c7382 (Include bundle manifests and Dockerfile, 2023-08-08, openshift#173) suggests I could have done this with 'make bundle VERSION=5.0.3-dev' or some such, but I don't have operator-sdk installed at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran an existing
Makefiletarget /shrug:The bundle will not work by itself: we are not publishing the operator images anywhere (except the productized images ofc) and we are not publishing cincinnati images anywhere suitable either (quay.io/cincinnati/cincinnati:latest is stale and quay.io/app-sre/cincinnati does not have floating or even version tags).
So for now this work should just support building the bundles from pull request code for the purpose of testing operator and operand PRs in CI and by QE, see openshift/release#42053