Skip to content

Conversation

@LalatenduMohanty
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@LalatenduMohanty LalatenduMohanty changed the title Adding all the edges to 4.3.0 because of an blocking bz 1793635 Blocking all the edges to 4.3.0 because of bz 1793635 Jan 22, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@wking
Copy link
Member

wking commented Jan 22, 2020

Probably for rc.3 as well, right? With at least the GCP bug, and also potentially any of these that were unfixed at that point (or a comment about them being fixed by rc.3?).

@jwforres
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwforres, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,jwforres]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LalatenduMohanty
Copy link
Member Author

Probably for rc.3 as well, right? With at least the GCP bug, and also potentially any of these that were unfixed at that point (or a comment about them being fixed by rc.3?).

That would be a different PR.

@openshift-merge-robot openshift-merge-robot merged commit 4cb1deb into openshift:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants