Skip to content

Conversation

@thiagoalessio
Copy link
Member

No description provided.

@sdodson
Copy link
Member

sdodson commented Mar 25, 2020

/lgtm
Successful upgrades in release controller and I've verified the release is signed properly.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@vrutkovs
Copy link

  • 4.3.5 -> 4.3.9 upgrade on GCP failed:
E ns/e2e-k8s-service-upgrade-9162 svc/service-test Service is not responding to GET requests over new connections
  • 4.3.5 and 4.3.8 > 4.3.9 upgrade on Azure failed:
OpenShift API stopped responding to GET requests: the server is currently unable to handle the request (get imagestreams.image.openshift.io missing)

@vrutkovs
Copy link

/cc @eparis

@wking
Copy link
Member

wking commented Mar 26, 2020

Need to block 4.2 -> 4.3 for this like #136, right? Bug is still open in 4.3

@wking wking mentioned this pull request Mar 26, 2020
@eparis
Copy link
Member

eparis commented Mar 26, 2020

Do I get candidate-4.4?

@wking
Copy link
Member

wking commented Mar 26, 2020

Also, we might want to batch candidate-4.4 addition in here too? I don't see a reason to split those apart now that we are promoting on a schedule with update monitoring just leading to blocked edges. Certainly not for candidate promotions.

@sdodson
Copy link
Member

sdodson commented Mar 26, 2020

Yes, we should do candidate-4.4 here and going forward.
I'm indifferent about blocking edges before we land this into candidate. One side of the coin is that we know we'll be blocking by the time this goes to fast and stable. The other side is we're not getting any early feedback that we regressed something between 4.2.z and 4.3.9 so that we could fix it before 4.3.10. So /shrug

@eparis
Copy link
Member

eparis commented Mar 26, 2020

/lgtm cancel
add it back when we fix candidate-4.4

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@wking
Copy link
Member

wking commented Mar 26, 2020

Orthogonal edge-block PR in #146. If CI passes there, we can land that anytime, even before this PR lands if we want to hide the edge from candidate. Or we can merge it anytime before #142 lands.

@wking
Copy link
Member

wking commented Mar 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@sdodson
Copy link
Member

sdodson commented Mar 27, 2020

@eparis fixed up

@LalatenduMohanty
Copy link
Member

/lgtm

@eparis
Copy link
Member

eparis commented Mar 27, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, LalatenduMohanty, sdodson, thiagoalessio, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 61f8a42 into openshift:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants