Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 23, 2020

Seems like a low-probability flake (we've had many successful 4.2->4.3 before seeing this), but we don't have a recovery procedure yet, so pull the edges while we get more details.

https://bugzilla.redhat.com/show_bug.cgi?id=1816302

@wking
Copy link
Member Author

wking commented Mar 23, 2020

https://bugzilla.redhat.com/show_bug.cgi?id=1816302#c4 has a recovery procedure (deleting a stuck pod). Not clear to me whether that impacts edge-blocking or not, since we're still not clear on whether this is a regression.

@sdodson
Copy link
Member

sdodson commented Mar 24, 2020

/hold
I'm fine with this sitting edge in candidate right now. We should however firm up our understanding of remediation and the scope of clusters we expect to be affected before we decide what happens with fast-4.3.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@LalatenduMohanty
Copy link
Member

I'm fine with this sitting edge in candidate right now. We should however firm up our understanding of remediation and the scope of clusters we expect to be affected before we decide what happens with fast-4.3.

Right, we can remove the blocking edge for 4.3.8 which is in candidate. Other than that we should be blocking the edge. We can come back and add the edges back if we find new information to support it.

@LalatenduMohanty
Copy link
Member

/lgtm cancel
lets remove the blocking edge for 4.3.8 which is in candidate channel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@sdodson
Copy link
Member

sdodson commented Mar 24, 2020

/hold cancel
/lgtm
Now that 4.3.8 is ready to promote into fast lets go ahead and block 4.2 to 4.3. We can come back and drop this block once we have a better risk assessment.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@LalatenduMohanty
Copy link
Member

/lgtm

@eparis
Copy link
Member

eparis commented Mar 24, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
Seems like a low-probability flake (we've had many successful 4.2->4.3
before seeing this), but we don't have a recovery procedure yet, so
pull the edges while we get more details.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@sdodson
Copy link
Member

sdodson commented Mar 24, 2020

rebased
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, LalatenduMohanty, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0714dd6 into openshift:master Mar 24, 2020
@wking wking mentioned this pull request Mar 26, 2020
@wking wking deleted the podIP-vs-podIPs branch March 31, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants