Skip to content

Conversation

@hongkailiu
Copy link
Member

@openshift-ci-robot openshift-ci-robot requested a review from a team December 24, 2019 01:58
@hongkailiu hongkailiu changed the title Add hack/migrate_jobs.py [WIP]Add hack/migrate_jobs.py Dec 24, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2019
@hongkailiu
Copy link
Member Author

Should migrate the job even if it is not a ci-operator job.

(p3env) ➜  ci-tools git:(mig_jobs) release_repo=/Users/hongkliu/repo/openshift/release bash -c 'find ${release_repo}  -name "*openshift-installer-master-presubmits.yaml" -exec python3 hack/migrate_jobs.py {} \;'
WARNING:root:ignoring job pull-ci-openshift-installer-shellcheck whose image quay.io/coreos/shellcheck-alpine:v0.5.0 is not ci-operator:latest
WARNING:root:ignoring job pull-ci-openshift-installer-tf-fmt whose image quay.io/coreos/terraform-alpine:v0.12.0-rc1 is not ci-operator:latest
WARNING:root:ignoring job pull-ci-openshift-installer-tf-lint whose image quay.io/coreos/tflint is not ci-operator:latest
WARNING:root:ignoring job pull-ci-openshift-installer-yaml-lint whose image quay.io/coreos/yamllint is not ci-operator:latest

@hongkailiu hongkailiu changed the title [WIP]Add hack/migrate_jobs.py Add hack/migrate_jobs.py Dec 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2019
@stevekuznetsov
Copy link
Contributor

Yes, we should migrate those jobs as well and if they're not running ci-operator it should be even easier to migrate.

@hongkailiu
Copy link
Member Author

Yes, we should migrate those jobs as well and if they're not running ci-operator it should be even easier to migrate.

Ack. They will be migrated (i.e., with cluster in the job def.), but they wont be provided pull-secret file and so-on (since they are for ci-operator to use).

@hongkailiu
Copy link
Member Author

/retest

@hongkailiu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2020
@hongkailiu
Copy link
Member Author

/close

merge to #341

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: Closed this PR.

Details

In response to this:

/close

merge to #341

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants