Skip to content

Migrate openshift/origin/master to build01 #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hongkailiu wants to merge 1 commit into from
Closed

Migrate openshift/origin/master to build01 #341

hongkailiu wants to merge 1 commit into from

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Dec 20, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2019
@hongkailiu
Copy link
Member Author

hongkailiu commented Dec 20, 2019

/cc @openshift/openshift-team-developer-productivity-test-platform

@openshift-ci-robot openshift-ci-robot requested a review from a team December 20, 2019 16:57
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@hongkailiu hongkailiu mentioned this pull request Dec 20, 2019
Closed
This was referenced Feb 3, 2020
Closed
Closed
@hongkailiu hongkailiu changed the title Revert "Revert "Migrate openshift/origin/master to build01"" Duplicate migrated jobs for build01 Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2020
@hongkailiu
Copy link
Member Author

hongkailiu commented Feb 3, 2020

need retest after openshift/release#6999 merges.

@hongkailiu hongkailiu mentioned this pull request Feb 3, 2020
Merged
stevekuznetsov
stevekuznetsov reviewed Feb 3, 2020
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of confused about the code in this pull. Why do we have a Python tool as well as a Go tool? I thought you said we could:

  1. update the ci-operator configuration to be correct for both clusters
  2. duplicate jobs to point to the new cluster
  3. prove they work
  4. cut over

@hongkailiu hongkailiu changed the title Duplicate migrated jobs for build01 Migrate openshift/origin/master to build01 Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2020
@hongkailiu
Copy link
Member Author

hongkailiu commented Feb 11, 2020

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2020

@hongkailiu: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2020

@hongkailiu: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@droslean droslean Awaiting requested review from droslean

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hongkailiu @openshift-ci-robot @stevekuznetsov