Skip to content

Conversation

@bbguimaraes
Copy link
Contributor

In the Paleolithic era, our images used CentOS 7 and git 1.8:

openshift/ci-operator-prowgen#118 (comment)

(note the repository URL for extra nostalgia)

We are no longer using stone tools, so change the diff-filter to
something more reasonable. See:

https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---diff-filterACDMRTUXB82308203

In the Paleolithic era, our images used CentOS 7 and `git` 1.8:

openshift/ci-operator-prowgen#118 (comment)

(note the repository URL for extra nostalgia)

We are no longer using stone tools, so change the `diff-filter` to
something more reasonable.  See:

https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---diff-filterACDMRTUXB82308203
@openshift-ci openshift-ci bot requested review from hongkailiu and smg247 May 24, 2022 08:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@smg247
Copy link
Member

smg247 commented May 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 19699a1 and 8 for PR HEAD 75ba724 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

@bbguimaraes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 66ed807 into openshift:master May 25, 2022
@bbguimaraes bbguimaraes deleted the git branch May 25, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants