rehearse: detect cluster profile changes

[bbguimaraes]

• Changes to cluster profiles are identified.
• Jobs that use those profiles are chosen for rehearsal.
• Integration test verifies the above (see note below).
• ConfigMap manager is changed to also create cluster profiles.
• Jobs are changed to use those CMs.
• More thorough unit testing.

Follow-up:

• Integration tests with --allow-volumes (potentially fixed in On a template change, rehearse all cluster types. #122).
• ConfigMap create/update method (comment, rehearse: don't update existing configmaps #123).
• Load plugin config from Prow and use the updateconfig library to generate the CMs (comment).

[bbguimaraes]

pull-ci-openshift-ci-operator-prowgen-master-unit
--- FAIL: TestIntegration (0.07s)

/me confused

[bbguimaraes]

Only a few minor items left. The existing bits are unlikely to change, so this is in a reviewable state. I've removed the integration test bits for now to reduce the noise.

/cc @openshift/developer-productivity-test-platform

[droslean]

Nice start, But I don't like the idea of getting the cluster profile differences from git diff. I would prefer just comparing the bytes of the file. Also, for the cm name hash, we can get the hash from the cluster-profile's data.

[bbguimaraes]

Fixed an issue with the version of git we use in CI (1.8.3.1, which is now six years old) not recognizing lower-case letters as exclusion filters in --diff-filter.

[stevekuznetsov]

Everything here looks pretty good -- what's left?

[bbguimaraes]

Updated.

@stevekuznetsov
Everything here looks pretty good -- what's left?

See the description. I separated the three conditions that already existed before this PR. Those do not interfere with the code here and should be dealt with in separate PRs, IMO.

[petr-muller]

/lgtm
/hold

What's left for this to be WIP? Even your description checklist says it's complete and I agree the remaining items can be done as followups.

To me it looks good (btw I really like your code, reads nice and I like the fact that adding a feature are 99% additions and not changes).

[bbguimaraes]

Why, thank you =)

The WIP was just to give people a chance to check the commits addressing the latest review. I will squash the history and remove the label.

[stevekuznetsov]

/hold cancel
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, petr-muller, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bbguimaraes,petr-muller,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment