Skip to content

cmd/autoowners: Don't pull OWNERS_ALIASES when there is no OWNERS #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jun 30, 2021
Merged

cmd/autoowners: Don't pull OWNERS_ALIASES when there is no OWNERS #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/autoowners/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func getOwnersHTTP(fg FileGetter, orgRepo orgRepo, filenames ownersconfig.Filena
if _, nf := err.(*github.FileNotFound); nf {
logrus.WithField("orgRepo", orgRepo.repoString()).WithField("filename", filename).
Debug("Not found file in the upstream repo")
continue
break
}
return httpResult, err
}
Expand Down
6 changes: 2 additions & 4 deletions cmd/autoowners/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,8 @@ aliases:
Organization: "org4",
Repository: "repo4",
},
expectedHTTPResult: httpResult{
repoAliases: ra,
},
expectedError: nil,
expectedHTTPResult: httpResult{},
expectedError: nil,
},
{
description: "owner is with normal error",
Expand Down