cmd/autoowners: Don't pull OWNERS_ALIASES when there is no OWNERS #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
autoowners-no-aliases-without-owners
branch
from
0281e0d to
97169a8
Compare
wking
force-pushed
the
autoowners-no-aliases-without-owners
branch
from
97169a8 to
3d6c114
Compare
Seen in an autoowners call: $ go run ./cmd/autoowners -debug-mode -dry-run -target-dir ../origin -target-subdir test -config-subdir extended ... INFO[0000] ListOrgMembers(openshift, all) client=github INFO[0002] handling repo ... orgRepo=util/image INFO[0002] GetFile(util, image, OWNERS, ) client=github DEBU[0002] GetFile(util, image, OWNERS, ) finished client=github duration=574.249751ms DEBU[0002] Not found file in the upstream repo filename=OWNERS orgRepo=util/image INFO[0002] GetFile(util, image, OWNERS_ALIASES, ) client=github DEBU[0003] GetFile(util, image, OWNERS_ALIASES, ) finished client=github duration=479.108876ms DEBU[0003] Not found file in the upstream repo filename=OWNERS_ALIASES orgRepo=util/image WARN[0003] Ignoring the repo with no OWNERS file in the upstream repo. orgRepo=util/image ... No need to hit GitHub for OWNERS_ALIASES unless we have successfully retrieved an OWNERS which might reference aliases. The continue I'm replacing is from 3d0c6cc (Copy autoowners from release repo, 2019-09-04, openshift#115) [1]. [1]: openshift@3d0c6cc#diff-d9fc97e94b9e2c25a3bd5eec3f3439e533b9d2d347be59f97d10506f7d61574dR147
wking
force-pushed
the
autoowners-no-aliases-without-owners
branch
from
3d6c114 to
1cd1d66
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in an
autoownerscall:No need to hit GitHub for
OWNERS_ALIASESunless we have successfully retrieved anOWNERSwhich might reference aliases.The
continueI'm replacing is from 3d0c6cc (#115).