Skip to content

cmd/ocp-build-data-enforcer: Fix "to mach" -> "to match" typo #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 1, 2020
Merged

cmd/ocp-build-data-enforcer: Fix "to mach" -> "to match" typo #1157

openshift-merge-robot merged 1 commit into from
Oct 1, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Aug 25, 2020

Typo from fe83470 (#1106).

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Aug 25, 2020

Included in #1156
/cose

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Aug 25, 2020

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2020

@alvaroaleman: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the to-mach-typo branch August 25, 2020 01:01
@wking wking restored the to-mach-typo branch September 17, 2020 01:45
@wking
Copy link
Member Author

wking commented Sep 17, 2020

/reopen

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2020

@wking: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@wking
Copy link
Member Author

wking commented Sep 17, 2020

Re-opened and rebased onto master, because #1156 ended up getting closed.

@wking wking changed the title b/cmd/ocp-build-data-enforcer: Fix "to mach" -> "to match" typo cmd/ocp-build-data-enforcer: Fix "to mach" -> "to match" typo Sep 17, 2020
@wking wking mentioned this pull request Sep 17, 2020
Closed
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Sep 17, 2020

Good point. However we need to make sure that all currently open PRs are closed before we merge this, because we match by title and if we change the title, we won't match anymore.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@wking
Copy link
Member Author

wking commented Sep 17, 2020

I went ahead and closed openshift/cluster-version-operator#456, so we're ready for the replacement ;).

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Sep 17, 2020

I went ahead and closed openshift/cluster-version-operator#456, so we're ready for the replacement ;).

Not really: https://github.com/search?q=is%3Apr+author%3Aopenshift-bot+is%3Aopen+baseimage&type=Issues&pr=true

@wking
Copy link
Member Author

wking commented Sep 17, 2020

Yeah, I'll let other teams merge or close as they see fit. Using the mass commenter would allow DPTP to mass-close if you want, but I'm not in a hurry here.

@wking
cmd/ocp-build-data-enforcer: Fix "to mach" -> "to match" typo
7c13493 
Typo from fe83470 (OCP build data enforcer: Add pr creation
capabilities, 2020-08-12, openshift#1106).
@wking
Copy link
Member Author

wking commented Sep 25, 2020 •
edited
Loading

Rebased again with 947413d -> 7c13493. Query shows openshift/cluster-resource-override-admission-operator#37 as the only remaining PR from the last series. Doesn't seem that disruptive to land this PR, close that one, and have it replaced without the typo. Or maybe the outstanding PR will land before the next series...

petr-muller
petr-muller approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 PR sounds manageable to me.

/hold

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@petr-muller
Copy link
Member

petr-muller commented Sep 25, 2020

Merge, wait for new image, retitle the PR should do the trick.

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Oct 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 619f3c5 into openshift:master Oct 1, 2020
@wking wking deleted the to-mach-typo branch October 1, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @alvaroaleman @openshift-ci-robot @petr-muller @openshift-merge-robot