OCP build data reporter: Using static string for title #1156
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
While we're here can we make "baseimages" into English? "base images" ?
Otherwise we don't find our own PRs and get 422 when creating a PR. Sample: This [query](0) doesn't find this [PR](1) resulting in a [http 422 from github](2). [0] https://github.com/search?q=is%3Aopen+is%3Apr+archived%3Afalse+in%3Atitle+repo%3Aopenshift%2Foc+author%3Aopenshift-bot+author%3Aopenshift-bot+Updating+images%2Fcli-artifacts%2FDockerfile.rhel+baseimages+to+mach+ocp-build-data+config [1] https://github.com/openshift/oc/pulls [2] https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/11197/rehearse-11197-periodic-ocp-build-data-enforcer/1298034546809245696#1:build-log.txt%3A1802
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
We have to be very careful with this because of compatibility reasons and I need to figure out why it manages more than one dockerfile in the first place. |
|
I'm not sure what happened in that PR. We create one PR per ocp-build-data config which in turn also references a file. The source branchname and the title are the same (modulo sanitation). In the example for oc, for some reason the title was changed to not include the correct dockerfile anymore |
3 participants
Otherwise we don't find our own PRs and get 422 when creating a PR.
Sample:
This query doesn't find this PR resulting in a http 422 from
github.
[0] https://github.com/search?q=is%3Aopen+is%3Apr+archived%3Afalse+in%3Atitle+repo%3Aopenshift%2Foc+author%3Aopenshift-bot+author%3Aopenshift-bot+Updating+images%2Fcli-artifacts%2FDockerfile.rhel+baseimages+to+mach+ocp-build-data+config
[1] https://github.com/openshift/oc/pulls
[2] https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/11197/rehearse-11197-periodic-ocp-build-data-enforcer/1298034546809245696#1:build-log.txt%3A1802
Fixes #1152