Bug 2037638: Add support for build csi volume source by jkhelil · Pull Request #273 · openshift/builder

jkhelil · 2021-11-17T09:20:02Z

https://issues.redhat.com/browse/BUILD-275

jkhelil · 2021-12-03T13:48:06Z

/test e2e-aws

jkhelil · 2021-12-03T17:44:58Z

/test e2e-aws-cgroupsv2
/test e2e-aws-proxy
/test openshift-e2e-aws-builds-techpreview

jkhelil · 2021-12-06T08:36:59Z

/test e2e-aws-proxy

jkhelil · 2021-12-06T11:59:46Z

/test openshift-e2e-aws-builds-techpreview

gabemontero · 2021-12-06T15:20:39Z

/retitle BUILD-275: add support for build csi volume source

gabemontero · 2021-12-06T15:36:54Z

if you think this is ready for review @jkhelil you'll minimally need to /assign either / both @adambkaplan and @coreydaley to this PR, as they approvers noted in https://github.com/openshift/builder/blob/master/OWNERS per the PR comment #273 (comment)

the e2e's are all green now.

per you comment in slack, I'm assuming test coverage for this is a new e2e in openshift/origin#26646 ... is that correct?

Based on my experience, that seems OK, as adding unit tests for the path you have had to manipulate in daemonless.go is not something that has been tenable in the past. Looking @coreydaley 's #245 when he added secret/configmap volumes, he touched the daemonless_test.go file, but seems to be for some semi-orthogonal cleanup that I don't think translates to your change here.

But I'll defer to @adambkaplan / @coreydaley .... otherwise I'm bowing out of this PR.

jkhelil · 2021-12-07T04:39:05Z

/assign @adambkaplan
/assign @coreydaley

adambkaplan

/approve

Looks good to me, modulo the api bump

coreydaley · 2021-12-08T20:41:04Z

/hold
pending openshift/api#1056

jkhelil · 2021-12-09T14:03:22Z

/test e2e-aws-builds

jkhelil · 2021-12-13T07:00:05Z

/test e2e-aws-builds-rhel7

jkhelil · 2022-01-05T12:37:07Z

/test e2e-aws-cgroupsv2

gabemontero · 2022-01-05T14:01:00Z

/hold cancel

bump @adambkaplan - I think we have another override rhel7 e2e candidate .... I will be trying to look into this today

/assign @prietyc123
for qe label

/assign @rolfedh
for docs label ... there is a docs impact with this story ... this is the last piece for supporting entitled builds via shared resources

/label px-approved

gabemontero · 2022-01-05T14:01:10Z

/lgtm

openshift-ci · 2022-01-05T14:02:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jkhelil · 2022-01-05T14:16:12Z

/assign @adambkaplan

openshift-bot · 2022-01-05T14:32:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-05T14:45:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

adambkaplan · 2022-01-05T17:04:52Z

/override ci/prow/e2e-aws-builds-rhel7

Known issue

openshift-ci · 2022-01-05T17:05:28Z

@adambkaplan: Overrode contexts on behalf of adambkaplan: ci/prow/e2e-aws-builds-rhel7

Details

In response to this:

/override ci/prow/e2e-aws-builds-rhel7

Known issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-05T17:05:29Z

@jkhelil: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jkhelil · 2022-01-06T08:07:05Z

/bugzilla refresh

openshift-ci · 2022-01-06T08:07:06Z

@jkhelil: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-06T08:07:25Z

@jkhelil: This pull request references Bugzilla bug 2037638, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 2037638: add support for build csi volume source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-06T08:08:41Z

@jkhelil: All pull requests linked via external trackers have merged:

openshift/builder#273

Bugzilla bug 2037638 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2037638: Add support for build csi volume source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from adambkaplan and coreydaley November 17, 2021 09:21

jkhelil changed the title ~~add support for build csi volume source~~ WIP build-275: add support for build csi volume source Nov 17, 2021

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2021

jkhelil changed the title ~~WIP build-275: add support for build csi volume source~~ build-275: add support for build csi volume source Nov 18, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2021

openshift-ci bot changed the title ~~build-275: add support for build csi volume source~~ BUILD-275: add support for build csi volume source Dec 6, 2021

openshift-ci bot assigned adambkaplan and coreydaley Dec 7, 2021

adambkaplan reviewed Dec 8, 2021

View reviewed changes

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021

jkhelil force-pushed the build-275 branch from 4dc3299 to b85b37a Compare December 9, 2021 07:39

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2021

jkhelil force-pushed the build-275 branch from b85b37a to c7635c9 Compare December 15, 2021 13:59

jkhelil added 2 commits January 5, 2022 09:47

add support for build csi volume source

06b88ad

bump openshift/api to handle new csi volume type

2b9946e

jkhelil force-pushed the build-275 branch from c7635c9 to 2b9946e Compare January 5, 2022 08:50

openshift-ci bot assigned prietyc123 Jan 5, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022

openshift-ci bot assigned rolfedh Jan 5, 2022

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 5, 2022

openshift-ci bot assigned gabemontero Jan 5, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022

jkhelil changed the title ~~BUILD-275: add support for build csi volume source~~ Bug 2037638 : add support for build csi volume source Jan 6, 2022

jkhelil changed the title ~~Bug 2037638 : add support for build csi volume source~~ Bug 2037638: add support for build csi volume source Jan 6, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 6, 2022

jkhelil changed the title ~~Bug 2037638: add support for build csi volume source~~ Bug 2037638: Add support for build csi volume source Jan 6, 2022

openshift-ci bot requested a review from jitendar-singh January 6, 2022 08:07

openshift-merge-robot merged commit 6409cc6 into openshift:master Jan 6, 2022

Conversation

jkhelil commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkhelil commented Dec 3, 2021

Uh oh!

jkhelil commented Dec 3, 2021

Uh oh!

jkhelil commented Dec 6, 2021

Uh oh!

jkhelil commented Dec 6, 2021

Uh oh!

gabemontero commented Dec 6, 2021 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabemontero commented Dec 6, 2021

Uh oh!

jkhelil commented Dec 7, 2021

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

coreydaley commented Dec 8, 2021

Uh oh!

jkhelil commented Dec 9, 2021

Uh oh!

jkhelil commented Dec 13, 2021

Uh oh!

jkhelil commented Jan 5, 2022

Uh oh!

gabemontero commented Jan 5, 2022

Uh oh!

gabemontero commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

jkhelil commented Jan 5, 2022

Uh oh!

openshift-bot commented Jan 5, 2022

Uh oh!

openshift-bot commented Jan 5, 2022

Uh oh!

adambkaplan commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

jkhelil commented Jan 6, 2022

Uh oh!

openshift-ci bot commented Jan 6, 2022

Uh oh!

openshift-ci bot commented Jan 6, 2022

Uh oh!

openshift-ci bot commented Jan 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Comments

jkhelil commented Nov 17, 2021 •

edited

Loading

gabemontero commented Dec 6, 2021 •

edited by openshift-ci bot

Loading