Skip to content

build-275: add CSI build source volume to build api#1056

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jkhelil:build-275
Dec 15, 2021
Merged

build-275: add CSI build source volume to build api#1056
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jkhelil:build-275

Conversation

@jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Nov 15, 2021

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkhelil please run make update to ensure all appropriate functions are regenerated (example - deepcopy functions).

@jkhelil jkhelil changed the title add CSI build source volume to build api WIP add CSI build source volume to build api Nov 17, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2021
@jkhelil jkhelil changed the title WIP add CSI build source volume to build api WIP build-275: add CSI build source volume to build api Nov 17, 2021
@jkhelil jkhelil changed the title WIP build-275: add CSI build source volume to build api build-275: add CSI build source volume to build api Nov 18, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2021
@jkhelil
Copy link
Contributor Author

jkhelil commented Nov 18, 2021

/retest

@jkhelil
Copy link
Contributor Author

jkhelil commented Nov 24, 2021

/test unit

@adambkaplan
Copy link
Contributor

/hold

We shouldn't merge until all the code is ready (openshift-apiserver, openshift-controller-manager, builder).

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@adambkaplan
Copy link
Contributor

@jkhelil looks like the deep copy functions did not update - are you sure you committed all changes from make update?

@adambkaplan
Copy link
Contributor

@jkhelil I had success running make generate-in-container, which runs the make update commands inside a container that has all the tooling dependencies installed.

The make target defaults to podman as the container, if you are using docker you can run make generate-in-container RUNTIME=docker

@adambkaplan
Copy link
Contributor

You also need to ensure that your _output directory is empty - I got bit by this in my first attempt.

@jkhelil
Copy link
Contributor Author

jkhelil commented Dec 7, 2021

/assign @adambkaplan
/assign @coreydaley

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic items on the godoc for the API, otherwise looks good to me.

@jkhelil
Copy link
Contributor Author

jkhelil commented Dec 9, 2021

/assign @adambkaplan can you approve/lgtm
/assign @coreydaley can you lgtm

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adambkaplan
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 9, 2021
@coreydaley
Copy link

/assign @sttts

@adambkaplan
Copy link
Contributor

bump @sttts

@adambkaplan
Copy link
Contributor

/cc @bparees @deads2k

@openshift-ci openshift-ci bot requested a review from deads2k December 14, 2021 18:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@jkhelil
Copy link
Contributor Author

jkhelil commented Dec 15, 2021

/assign @bparees
/assign @sttts

@sttts
Copy link
Contributor

sttts commented Dec 15, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, jkhelil, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@jkhelil: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7c47a5f into openshift:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments