build-275: add CSI build source volume to build api#1056
build-275: add CSI build source volume to build api#1056openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
adambkaplan
left a comment
There was a problem hiding this comment.
@jkhelil please run make update to ensure all appropriate functions are regenerated (example - deepcopy functions).
|
/retest |
|
/test unit |
|
/hold We shouldn't merge until all the code is ready (openshift-apiserver, openshift-controller-manager, builder). |
|
@jkhelil looks like the deep copy functions did not update - are you sure you committed all changes from |
|
@jkhelil I had success running The make target defaults to podman as the container, if you are using docker you can run |
|
You also need to ensure that your |
|
/assign @adambkaplan |
adambkaplan
left a comment
There was a problem hiding this comment.
Cosmetic items on the godoc for the API, otherwise looks good to me.
c5ab4e5 to
97a792b
Compare
|
/assign @adambkaplan can you approve/lgtm |
|
/hold cancel |
|
/assign @sttts |
|
bump @sttts |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, jkhelil, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jkhelil: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/BUILD-275