-
Notifications
You must be signed in to change notification settings - Fork 61
Bug 1907573: Update buildah to v1.14.11 #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1907573: Update buildah to v1.14.11 #198
Conversation
|
@adambkaplan: An error was encountered adding this pull request to the external tracker bugs for bug 1907573 on the Bugzilla server at https://bugzilla.redhat.com:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @nalind /cc @coreydaley |
|
/bugzilla refresh |
|
@adambkaplan: An error was encountered adding this pull request to the external tracker bugs for bug 1907573 on the Bugzilla server at https://bugzilla.redhat.com:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I'd suggest this to get things compiling again: |
|
/hold Need to re-do this once the k8s rebase merges. |
a25ec43 to
0de803a
Compare
|
@adambkaplan: This pull request references Bugzilla bug 1907573, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Rebased this on top of #195 - that PR should land first. |
|
Hold remains, waiting on #195 to land first. |
|
/bugzilla cc-qa |
|
@wewang58: This pull request references Bugzilla bug 1907573, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Since pr195 already merged, so used cluster-bot lauched a cluster with version:4.4.0-0.ci.test-2021-01-25-023159-ci-ln-bknwdhk, when build, found error: |
- Bump github.com/openshift/source-to-image to v1.3.0 to address dependency skews which prove problematic for go.mod. - Pin github.com/containerd/containerd to v1.3.6 to resolve transitive dependencies on 0.y versions of containerd/containerd. - Switch github.com/docker/docker back to an upstream pseudoversion that aligns better with containers/image. - Pin golang.org/x/crypto to ensure dependencies include a fix for CVE-2020-9283. - Remove google.golang.org/grpc pin - no longer required and was problematic with updated docker/docker version. - Removed pin on github.com/moby/buildkit fork - not needed with s2i bump. - Bump github.com/containers/buildah to v1.14.11, along with its dependencies: - github.com/containers/conmon to v0.8.4 - github.com/containers/image/v5 to v5.4.3 - github.com/containers/storage to v1.18.2 - github.com/openshift/imagebuilder to v1.1.4 - github.com/spf13/cobra to v0.0.7 - golang.org/x/sys to 20200327173247-9dae0f8f5775 Other updates the result of `go mod tidy && go mod vendor`.
0de803a to
f337023
Compare
|
@wewang58 please review again. We made a change to the rpms that openshift/builder requires, and I needed to rebase the PR as a result. |
|
@adambkaplan Launched a cluster using cluster-bot, now builds complete |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, wewang58 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@adambkaplan: All pull requests linked via external trackers have merged: Bugzilla bug 1907573 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick of #169 and #166
dependency skews which prove problematic for go.mod.
dependencies on 0.y versions of containerd/containerd.
aligns better with containers/image.
CVE-2020-9283.
problematic with updated docker/docker version.
bump.
dependencies:
Other updates the result of
go mod tidy && go mod vendor.