-
Notifications
You must be signed in to change notification settings - Fork 61
Bug 1889954: bump(*) to mitigate CVE-2020-8564 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1889954: bump(*) to mitigate CVE-2020-8564 #195
Conversation
|
@coreydaley: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @adambkaplan |
|
@coreydaley: This pull request references Bugzilla bug 1889954, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/bugzilla refresh |
|
@coreydaley: This pull request references Bugzilla bug 1889954, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| github.com/opencontainers/runc v1.0.0-rc9 | ||
| github.com/opencontainers/runtime-spec v1.0.0 | ||
| github.com/openshift/api v3.9.1-0.20191024142031-e89ff1fddcbe+incompatible | ||
| github.com/openshift/api v0.0.0-20200618202633-7192180f496a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this api bump come from? This appears to be from a later OpenShift release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the latest commit in the release-4.4 branch of the openshift/api repository: openshift/api@7192180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indicate in the commit message that you are bumping openshift/api, and the reason for doing so. I assume you did this to get around an "invalid pseudo-version" error? I found something similar in a separate item I was iterating on.
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the git commit message and PR description to provide more details.
| github.com/opencontainers/runc v1.0.0-rc9 | ||
| github.com/opencontainers/runtime-spec v1.0.0 | ||
| github.com/openshift/api v3.9.1-0.20191024142031-e89ff1fddcbe+incompatible | ||
| github.com/openshift/api v0.0.0-20200618202633-7192180f496a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indicate in the commit message that you are bumping openshift/api, and the reason for doing so. I assume you did this to get around an "invalid pseudo-version" error? I found something similar in a separate item I was iterating on.
|
/approve |
bumping openshift/api to work around invalid pseudo-version issue
|
Commit messages updated |
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/bugzilla cc-qa |
|
@wewang58: This pull request references Bugzilla bug 1889954, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@wewang58: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I see, The repo does not support qe-approve label |
|
(patch manager) If this is CVE related, the severity should probably be bumped? We typically only merge high/urgent in 4.4 right now |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
These failures seem to be pretty common. @coreydaley can you look into this? /hold |
ah ... if this PR is hitting that @coreydaley @crawford this was address in master/4.7 via an fix to the test in openshift/origin via openshift/origin#25799 to date it has only been backported to 4.6 via openshift/origin#25804 if we want to hold this on that test, vs. overriding it, we can add a 4.5 cherrypick to the 4.6 PR, get it merged, then do the 4.4 from the merged 4.5 PR which way do you want to proceed @crawford ? |
|
@gabemontero let's backport the test. Can you trigger those for me? |
openshift/origin#25816 up for 4.5 @crawford ... added assignments for requisite approve/lgtm and cherrypick for 4.4 in that PR |
|
openshift/origin#25817 has merged. /hold cancel |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@coreydaley: All pull requests linked via external trackers have merged: Bugzilla bug 1889954 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.