Skip to content

Bug 1872080: Add Dockerfile.openshift for CI #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bcrochet merged 1 commit into from
Sep 1, 2020
Merged

Bug 1872080: Add Dockerfile.openshift for CI #93

bcrochet merged 1 commit into from
Sep 1, 2020

Conversation

@bcrochet
Copy link
Member

@bcrochet bcrochet commented Sep 1, 2020

We want to use this Dockerfile for CI so that local builds will continue
to use the ubi8 image.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@cybertron
Copy link
Member

cybertron commented Sep 1, 2020

So this would be used for ci and product builds as defined by https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/baremetal-runtimecfg.yml right? Should this be called Dockerfile.openshift instead, since we're already using a rhel8-based image in the regular Dockerfile?

@bcrochet
Copy link
Member Author

bcrochet commented Sep 1, 2020

So this would be used for ci and product builds as defined by https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/baremetal-runtimecfg.yml right? Should this be called Dockerfile.openshift instead, since we're already using a rhel8-based image in the regular Dockerfile?

Don't care what it's called. Dockerfile.openshift does work better for me.

@bcrochet
Add Dockerfile.openshift for CI
0c7c0ed 
We want to use this Dockerfile for CI so that local builds will continue
to use the ubi8 image.
@bcrochet
Copy link
Member Author

bcrochet commented Sep 1, 2020

/retitle Add Dockerfile.openshift for CI

@openshift-ci-robot openshift-ci-robot changed the title Add Dockerfile.rhel8 for CI Add Dockerfile.openshift for CI Sep 1, 2020
@bcrochet bcrochet mentioned this pull request Sep 1, 2020
Merged
@cybertron
Copy link
Member

cybertron commented Sep 1, 2020

/lgtm

Looks like we will need a bug for this to merge.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet
Copy link
Member Author

bcrochet commented Sep 1, 2020

/retitle Bug 1872080: Add Dockerfile.openshift for CI

@openshift-ci-robot openshift-ci-robot changed the title Add Dockerfile.openshift for CI Bug 1872080: Add Dockerfile.openshift for CI Sep 1, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 1, 2020

@bcrochet: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1872080: Add Dockerfile.openshift for CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bcrochet
Copy link
Member Author

bcrochet commented Sep 1, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 1, 2020

@bcrochet: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bcrochet
Copy link
Member Author

bcrochet commented Sep 1, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 1, 2020

@bcrochet: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bcrochet bcrochet merged commit 029e04b into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 1, 2020

@bcrochet: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1872080: Add Dockerfile.openshift for CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 1, 2020
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 1, 2020

@bcrochet: new pull request created: #94

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford crawford mentioned this pull request Sep 1, 2020
Closed
yselkowitz pushed a commit to yselkowitz/ocp-build-data that referenced this pull request Sep 10, 2020
@bcrochet @yselkowitz
[baremetal-runtimecfg] Use Dockerfile.openshift instead of Dockerfile
3a7f3f0 
This change is in support of bugzilla 1872080. It modifies the
configuration file for the baremetal-runtimecfg component by adjusting their
dockerfile to match the newly created "Dockerfile.openshift" file.

This change also depends on another pull request and should not be
merged until they are:
openshift/baremetal-runtimecfg#93
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@yboaron yboaron Awaiting requested review from yboaron

Assignees

@cybertron cybertron

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcrochet @cybertron @openshift-ci-robot @openshift-cherrypick-robot