-
Notifications
You must be signed in to change notification settings - Fork 45
Bug 1872080: Updating Dockerfile baseimages to mach ocp-build-data config #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| RUN GO111MODULE=on go build --mod=vendor cmd/unicastipserver/unicastipserver.go | ||
|
|
||
| FROM registry.access.redhat.com/ubi8/ubi:latest | ||
| FROM registry.svc.ci.openshift.org/ocp/4.6:base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking my local build. Evidently the 4.6 base image is still RHEL 7-based.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has since changed to RHEL 8.
|
@openshift-bot: An error was encountered adding this pull request to the external tracker bugs for bug 1872080 on the Bugzilla server at https://bugzilla.redhat.com:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@crawford: This pull request references Bugzilla bug 1872080, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @celebdor |
|
I'm getting the same thing as @cybertron . Seeing this: STEP 10: RUN yum install -y dhclient diffutils && yum clean all
|
|
Are you seeing that error trying to build the image yourself, or in automated builds? The address is only available within CI. |
Locally built myself. If so, that will be a problem for testing changes locally. I think we'll need to introduce a Dockerfile.rhel8 and modify CI to use that. Can you go ahead and copy Dockerfile to Dockerfile.rhel8 as part of this patch so we can then point CI to that without having to open a new patch? |
|
No, I can't, as this PR was filed by a bot. |
Ok. I'll file a follow on. |
|
Superseded by #93. |
|
@crawford: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: This pull request references Bugzilla bug 1872080. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.
If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.