Bug 1948311: DelegatingAuthenticationOptions TokenReview request timeout #126
Conversation
openshift-ci
bot
added
the
bugzilla/severity-urgent
|
@ingvagabund: This pull request references Bugzilla bug 1948311, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
| // do not set a timeout on the http client, instead use context for cancellation | ||
| // if multiple timeouts were set, the request will pick the smaller timeout to be applied, leaving other useless. | ||
| // | ||
| // see https://github.com/golang/go/blob/a937729c2c2f6950a32bc5cd0f5b88700882f078/src/net/http/client.go#L364 |
| // if the child has a shorter deadline then it will expire first, | ||
| // otherwise if the parent has a shorter deadline then the parent will expire and it will be propagate to the child | ||
| if w.requestTimeout > 0 { | ||
| ctx, cancel = context.WithTimeout(ctx, w.requestTimeout) |
|
/lgtm |
|
/approve |
|
@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-aws-csi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, jsafrane, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ingvagabund: An error was encountered checking the state of a related pull request at kubernetes/kubernetes#101022 for bug 1948311 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Get "http://ghproxy/repos/kubernetes/kubernetes/pulls/101022": failed to get installation id for org kubernetes: the github app is not installed in organization kubernetes
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Reapply #121 undone by #116