Skip to content

Bug 1956411: Add custom tags from Infrastructure #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
May 4, 2021
Merged

Bug 1956411: Add custom tags from Infrastructure #116

openshift-merge-robot merged 2 commits into from
May 4, 2021

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 29, 2021 •
edited
Loading

Apply tags from Infrastructure.Status.PlatformStatus.AWS.ResourceTags to newly created volumes.

See openshift/enhancements#706 and merged API in openshift/api#864

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2021

@jsafrane: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
@jsafrane jsafrane changed the title WIP: Add custom tags from Infrastructure Add custom tags from Infrastructure May 3, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2021
@jsafrane jsafrane changed the title Add custom tags from Infrastructure Bug 1956411: Add custom tags from Infrastructure May 3, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 3, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 3, 2021

@jsafrane: This pull request references Bugzilla bug 1956411, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1956411: Add custom tags from Infrastructure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 3, 2021
jsafrane added 2 commits May 4, 2021 09:09
@jsafrane
Add custom tags from Infrastructure
ca71feb 
Apply tags from Infrastructure.Status.PlatformStatus.AWS.ResourceTags to newly
created volumes.
@jsafrane
Bump github.com/openshift/api to get AWS resource tags
242b69a
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2021

@jsafrane: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi-migration 242b69a link /test e2e-aws-csi-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Elbehery
Elbehery reviewed May 4, 2021
View reviewed changes
pkg/operator/starter.go
return err
}
if infra.Status.PlatformStatus == nil || infra.Status.PlatformStatus.AWS == nil {
return nil
Copy link
Contributor

@Elbehery Elbehery May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some logs ? ..
I can see the same func could return err as nil in many cases, logs could eventually help I guess

Elbehery
Elbehery approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@Elbehery Elbehery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 017cf78 into openshift:master May 4, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 4, 2021

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 1956411 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1956411: Add custom tags from Infrastructure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

1 more reviewer

@Elbehery Elbehery Elbehery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Elbehery Elbehery

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsafrane @openshift-ci-robot @Elbehery @openshift-merge-robot