Skip to content

[cloud_hotfix_releases] MGMT-17775: Ensure that patch manifest filenames are consistent and correct. - #6303

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6289-to-cloud_hotfix_releases
May 9, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6289-to-cloud_hotfix_releases

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6289

/assign paul-maidment

…orrect

This PR addresses a few bugs in docs, regexes and code that cause inconsistency in the handling of patch manifests.

Patch manifests should end with the extension `.patch` or should end with a suffixed patch extension such as `.patch_extension`
@openshift-ci-robot

openshift-ci-robot commented May 9, 2024 •

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17775

Details

In response to this:

This is an automated cherry-pick of #6289

/assign paul-maidment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2024
@openshift-ci
openshift-ci Bot requested review from danielerez and danmanor May 9, 2024 08:13
@openshift-ci openshift-ci Bot added the api-review Categorizes an issue or PR as actively needing an API review. label May 9, 2024
@gamli75

gamli75 commented May 9, 2024

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot

openshift-ci-robot commented May 9, 2024 •

Copy link
Copy Markdown

@gamli75: This pull request references MGMT-17775 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci

openshift-ci Bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@codecov

codecov Bot commented May 9, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (ef0c961) to head (61e3836).
Report is 995 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6303      +/-   ##
=========================================================
+ Coverage                  66.66%   68.22%   +1.56%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35864    +8338     
=========================================================
+ Hits                       18350    24468    +6118     
- Misses                      7531     9272    +1741     
- Partials                    1645     2124     +479     
Files Coverage Δ
internal/manifests/manifests.go 78.49% <100.00%> (+7.74%) ⬆️

... and 159 files with indirect coverage changes

@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 34e9389 and 2 for PR HEAD 61e3836 in total

@openshift-ci

openshift-ci Bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 86298d3 into openshift:cloud_hotfix_releases May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants