MGMT-17775: Ensure that patch manifest filenames are consistent and correct.

[paul-maidment]

This PR addresses a few bugs in docs, regexes and code that cause inconsistency in the handling of patch manifests.

Patch manifests should end with the extension .patch or should end with a suffixed patch extension such as .patch_extension

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-17775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This PR addresses a few bugs in docs, regexes and code that cause inconsistency in the handling of patch manifests.

Patch manifests should end with the extension .patch or should end with a suffixed patch extension such as .patch_extension

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (9a4ece9) to head (eb6c66d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6289      +/-   ##
==========================================
- Coverage   68.29%   68.28%   -0.01%     
==========================================
  Files         241      241              
  Lines       35858    35863       +5     
==========================================
+ Hits        24488    24489       +1     
- Misses       9211     9212       +1     
- Partials     2159     2162       +3     

Files	Coverage Δ
internal/manifests/manifests.go	78.49% <100.00%> (ø)

... and 3 files with indirect coverage changes

[ori-amizur]

/lgtm

[ori-amizur]

/lgtm

[gamli75]

can you add tests for valid and invalid file names?

[paul-maidment]

/hold Going to add more tests as per comment from @gamli75

[paul-maidment]

/retest

[openshift-ci]

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gamli75,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[paul-maidment]

/unhold

[paul-maidment]

/cherry-pick cloud_hotfix_releases

[openshift-cherrypick-robot]

@paul-maidment: new pull request created: #6303

Details

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202405100946.p0.g904ee71.assembly.stream.el9 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.