Skip to content

[cloud_hotfix_releases] NO-ISSUE: Change only-latest api response to compare versions according to pre-release suffix as well instead of just base version - #6226

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6209-to-cloud_hotfix_releases
Apr 19, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6209-to-cloud_hotfix_releases

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6209

/assign danmanor

…ng to pre-release suffix as well instead of just base version
@codecov

codecov Bot commented Apr 18, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (ef0c961) to head (c643b58).
Report is 992 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6226      +/-   ##
=========================================================
+ Coverage                  66.66%   68.31%   +1.65%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35958    +8432     
=========================================================
+ Hits                       18350    24566    +6216     
- Misses                      7531     9272    +1741     
- Partials                    1645     2120     +475     
Files Coverage Δ
internal/common/version.go 69.84% <ø> (+19.84%) ⬆️
internal/versions/api.go 81.01% <100.00%> (ø)

... and 158 files with indirect coverage changes

@rccrdpccl

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@rccrdpccl

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 19, 2024
@openshift-ci-robot

Copy link
Copy Markdown

@rccrdpccl: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 3d50ab0 and 2 for PR HEAD c643b58 in total

@openshift-ci

openshift-ci Bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit be095a1 into openshift:cloud_hotfix_releases Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants