NO-ISSUE: Change only-latest api response to compare versions according to pre-release suffix as well instead of just base version

[danmanor]

Currently in ../openshift-versions?only_latest=true request latest release images are compared with base version only, while this doesn't work for early beta releases. This PR fixed this issue by comparing all version.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@danmanor: This pull request explicitly references no jira issue.

Details

In response to this:

Change only-latest api response to compare versions according to pre-release suffix as well instead of just base version

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.37%. Comparing base (4dcebe4) to head (c99add9).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6209      +/-   ##
==========================================
+ Coverage   68.28%   68.37%   +0.09%     
==========================================
  Files         240      240              
  Lines       35815    35896      +81     
==========================================
+ Hits        24456    24545      +89     
+ Misses       9200     9198       -2     
+ Partials     2159     2153       -6     

Files	Coverage Δ
internal/common/version.go	69.84% <ø> (+0.27%)	⬆️
internal/versions/api.go	81.01% <100.00%> (+1.39%)	⬆️

... and 2 files with indirect coverage changes

[eifrach]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danmanor,eifrach]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danmanor]

/cherry-pick cloud_hotfix_releases

[openshift-cherrypick-robot]

@danmanor: once the present PR merges, I will cherry-pick it on top of cloud_hotfix_releases in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danmanor]

/cherry-pick cloud_hotfix_releases

[openshift-cherrypick-robot]

@danmanor: once the present PR merges, I will cherry-pick it on top of cloud_hotfix_releases in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eifrach]

/lgtm

[danmanor]

/retest

[openshift-ci]

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@danmanor: new pull request created: #6226

Details

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.