Skip to content

Comments

Eran/remove etcd patch#47

Closed
eranco74 wants to merge 1 commit intomasterfrom
eran/remove_etcd_patch
Closed

Eran/remove etcd patch#47
eranco74 wants to merge 1 commit intomasterfrom
eran/remove_etcd_patch

Conversation

@eranco74
Copy link
Contributor

@eranco74 eranco74 commented Sep 28, 2020

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2020
@eranco74
Copy link
Contributor Author

eranco74 commented Sep 28, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2020
romfreiman
romfreiman reviewed Sep 28, 2020
View reviewed changes
src/installer/installer.go
return err
}

if err := kc.PatchEtcd(); err != nil {
Copy link

@romfreiman romfreiman Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u're missing the unpatch

Copy link
Contributor Author

@eranco74 eranco74 Sep 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the unpatch from the controller and published a new image
quay.io/eranco74/assisted-installer:test

@eranco74 eranco74 force-pushed the eran/remove_etcd_patch branch from f274a89 to 7aa6f3a Compare September 29, 2020 10:22
@carbonin
Copy link
Member

carbonin commented Sep 29, 2020

I think you can also remove the related methods from src/k8s_client/mock_k8s_client.go and src/k8s_client/k8s_client.go

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2020

@eranco74: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2020
@carbonin carbonin mentioned this pull request Nov 23, 2020
Merged
@YuviGold
Copy link
Contributor

YuviGold commented Dec 17, 2020

Resolved on #115
/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2020

@YuviGold: Closed this PR.

Details

In response to this:

Resolved on #115
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp osherdp deleted the eran/remove_etcd_patch branch November 28, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romfreiman romfreiman romfreiman left review comments

@carbonin carbonin Awaiting requested review from carbonin

@tsorya tsorya Awaiting requested review from tsorya

@ronniel1 ronniel1 Awaiting requested review from ronniel1

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eranco74 @openshift-ci-robot @carbonin @YuviGold @romfreiman