MGMT-2454 Remove patch for unsupported etcd flag for versions >= 4.7

[carbonin]

Going forward we will use a marker file written to the bootstrap
node. This is implemented in the service in openshift/assisted-service#672
and the etcd operator in openshift/cluster-etcd-operator#449

We also need to consider what version of openshift will contain the
etcd operator enhancement we require before merging this.

Fixes MGMT-2454
Alternative to #47

[carbonin]

/hold until we are using a cluster version including openshift/cluster-etcd-operator#449

[carbonin]

Made this conditional on the version we're installing. Will unhold when I test with both 4.6 and 4.7

[romfreiman]

Please add a UT with 4.6.6 and 4.7.5 (just to verify patch releases are working).

[romfreiman]

Btw, lets not affect the current flow - meaning if this code will be deployed to the cloud now - will it work? Or it will require marking somewhere that it installs 4.6. If it wild require extra changes, then - not good 👎

[carbonin]

meaning if this code will be deployed to the cloud now - will it work?

I thought it would, but I'm hitting some issues running test infra. I'll know for sure tomorrow.

[carbonin]

Verified that this doesn't break 4.6, but waiting on the 4.7 MCO issue to continue testing that.

[carbonin]

Also just validated on 4.7 with nightly release 4.7.0-0.nightly-2020-12-10-202001

Validated that we didn't path or unpatch as well.

# grep -Rn "Skipping etcd" *
logs_host_f8384dab-5526-4418-a7e1-13e23bc331ce/installer.logs:406:Dec 16 19:53:33 test-infra-cluster-assisted-installer-master-1 installer[3042]: time="2020-12-16T19:53:33Z" level=info msg="Skipping etcd patch for cluster version 4.7"
# oc logs -n assisted-installer  assisted-installer-controller-wfc8f | grep "Skipping etcd unpatch"
time="2020-12-16T20:08:53Z" level=info msg="Skipping etcd unpatch for cluster version 4.7"

/unhold

Any other concerns @romfreiman @YuviGold @eranco74 ?

[romfreiman]

/lgtm

[romfreiman]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, romfreiman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [carbonin,romfreiman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment