-
Notifications
You must be signed in to change notification settings - Fork 585
Add BareMetal status for BareMetal platform #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -121,6 +121,10 @@ type PlatformStatus struct { | |
| // GCP contains settings specific to the Google Cloud Platform infrastructure provider. | ||
| // +optional | ||
| GCP *GCPPlatformStatus `json:"gcp,omitempty"` | ||
|
|
||
| // BareMetal contains settings specific to the BareMetal platform. | ||
| // +optional | ||
| BareMetal *BareMetalPlatformStatus `json:"baremetal,omitempty"` | ||
| } | ||
|
|
||
| // AWSPlatformStatus holds the current status of the Amazon Web Services infrastructure provider. | ||
|
|
@@ -144,6 +148,27 @@ type GCPPlatformStatus struct { | |
| Region string `json:"region"` | ||
| } | ||
|
|
||
| // BareMetalPlatformStatus holds the current status of the BareMetal infrastructure provider. | ||
| type BareMetalPlatformStatus struct { | ||
| // apiServerInternalIP is an IP address to contact the Kubernetes API server that can be used | ||
| // by components inside the cluster, like kubelets using the infrastructure rather | ||
| // than Kubernetes networking. It is the IP that the Infrastructure.status.apiServerInternalURI | ||
| // points to. It is the IP for a self-hosted load balancer in front of the API servers. | ||
| APIServerInternalIP string `json:"apiServerInternalIP,omitempty"` | ||
|
|
||
| // ingressIP is an external IP which routes to the default ingress controller. | ||
| // The IP is a suitable target of a wildcard DNS record used to resolve default route host names. | ||
| IngressIP string `json:"ingressIP,omitempty"` | ||
|
|
||
| // nodeDNSIP is the IP address for the internal DNS used by the | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not clear, what kind of DNS resolution would node's require? does it provides DNS resolution for infrastructure DNS records like internal LB, hostnames, etc....
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. It is for the node hostnames. Since baremetal does not have a DNSaaS, we want to minimize the amount of external datacenter DNS entries that would be necessary for a deployer to have to create.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will this IP return the address for |
||
| // nodes. Unlike the one managed by the DNS operator, `NodeDNSIP` | ||
| // provides name resolution for the nodes themselves. There is no DNS-as-a-service for | ||
| // BareMetal deployments. In order to minimize necessary changes to the | ||
| // datacenter DNS, a DNS service is hosted as a static pod to serve those hostnames | ||
| // to the nodes in the cluster. | ||
| NodeDNSIP string `json:"nodeDNSIP,omitempty"` | ||
bcrochet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| // InfrastructureList is | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.