Add BareMetal status for BareMetal platform #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
bcrochet
force-pushed
the
baremetal-status
branch
2 times, most recently
from
bde176c to
2449ee0
Compare
bcrochet
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
bcrochet
force-pushed
the
baremetal-status
branch
from
2449ee0 to
bc117e9
Compare
Member
Author
|
This is ready for review and merge. |
bcrochet
force-pushed
the
baremetal-status
branch
2 times, most recently
from
a4dd44c to
48827ae
Compare
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 18, 2019
…remetal.apivip Using openshift/api@48827ae4 (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
force-pushed
the
baremetal-status
branch
from
1716b08 to
68eff5f
Compare
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 20, 2019
…remetal.apivip Using openshift/api@3fcd094 (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 21, 2019
…remetal.apivip Using openshift/api@3fcd094 (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
soltysh
suggested changes
Jun 21, 2019
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Can you please squash your changes into a single commit?
bcrochet
force-pushed
the
baremetal-status
branch
from
e80d22c to
aa968ae
Compare
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 24, 2019
…remetal.apivip Using openshift/api@aa968ae (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
force-pushed
the
baremetal-status
branch
2 times, most recently
from
a38a6f1 to
3625215
Compare
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 26, 2019
…remetal.apivip Using openshift/api@3625215 (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 26, 2019
…remetal.apivip Using openshift/api@3625215 (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
force-pushed
the
baremetal-status
branch
from
3625215 to
6a276bd
Compare
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 26, 2019
…remetal.apivip Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 28, 2019
…remetal.apivip Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
bcrochet
added a commit
to bcrochet/kni-installer
that referenced
this pull request
Jun 28, 2019
…remetal.apivip Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API VIP in their configuration.
openshift-ci-robot
added
the
needs-rebase
bcrochet
force-pushed
the
baremetal-status
branch
from
6a276bd to
78afb54
Compare
deads2k
reviewed
Jul 12, 2019
bcrochet
force-pushed
the
baremetal-status
branch
from
8075366 to
e77022f
Compare
Contributor
|
doc looks good now, I understand what each field is for. I'm looking for someone on the install team to vet the information actually being included. |
Contributor
|
A lot more networking architecture docs are headed into the installer repo here: openshift/installer#1981 A rendered version that includes the above PR is here: https://github.com/russellb/installer/blob/baremetal-networking-docs/docs/design/baremetal/networking-infrastructure.md I'm interested in any feedback on these docs! I'm hoping they help explain these configuration items and how they fit into a /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/approve /assign @eparis |
openshift-ci-robot
added
the
approved
abhinavdahiya
suggested changes
Jul 12, 2019
| // The IP is a suitable target of a wildcard DNS record used to resolve default route host names. | ||
| IngressIP string `json:"ingressIP,omitempty"` | ||
|
|
||
| // nodeDNSIP is the IP address for the internal DNS used by the |
Contributor
There was a problem hiding this comment.
this is not clear, what kind of DNS resolution would node's require?
does it provides DNS resolution for infrastructure DNS records like internal LB, hostnames, etc....
Member
Author
There was a problem hiding this comment.
Yes. It is for the node hostnames. Since baremetal does not have a DNSaaS, we want to minimize the amount of external datacenter DNS entries that would be necessary for a deployer to have to create.
Contributor
There was a problem hiding this comment.
will this IP return the address for api-int.cluster_domain DNS name ?? or there's no change this will return the addressed for non-node-hostnames.
bcrochet
force-pushed
the
baremetal-status
branch
from
e77022f to
7e76e21
Compare
…atform This adds a BareMetal-specific status fields, akin to AWS status. It holds the API IP, the DNS IP, and the Ingress IP. The API IP is provided by the installer. It is a reserved IP that the installer provides that will first reside on the bootstrap node, and move to one of the masters once the cluster is functioning. The DNS IP will front a DNS service running on the bootstrap, and then the cluster itself, that will serve DNS internal to the cluster, and separate from the main cluster DNS service. It will serve etcd SRV records, as well as hostnames for the BareMetal hosts. The Ingress IP will be held by a node that runs an OpenShift router pod. An external datacenter DNS record will point the apps wildcard record there.
bcrochet
force-pushed
the
baremetal-status
branch
from
7e76e21 to
236890a
Compare
Contributor
|
LGTM |
Contributor
|
/lgtm install signed off |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/approve
@abhinavdahiya sorry, github didn't show me your comments until it merged :( You need a revert or can you work from here? |
Contributor
|
It's fine, follow-up will work. |
russellb
added a commit
to russellb/api
that referenced
this pull request
Jul 13, 2019
A recent PR (openshift#348) added the BareMetalPlatformStatus. Add a reference to a document that helps explain the networking architecture for the "baremetal" platform and how these IP addresses are used.
cybertron
pushed a commit
to cybertron/kni-installer
that referenced
this pull request
Jul 16, 2019
…tatus.baremetal Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API, DNS, and Ingress VIPs in their configuration. The vendored openshift/api is updated to pull in the new platform status definition.
cybertron
added a commit
to cybertron/installer
that referenced
this pull request
Jul 18, 2019
….baremetal Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API, DNS, and Ingress VIPs in their configuration.
cybertron
added a commit
to cybertron/installer
that referenced
this pull request
Jul 19, 2019
….baremetal Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API, DNS, and Ingress VIPs in their configuration.
cybertron
added a commit
to cybertron/installer
that referenced
this pull request
Jul 25, 2019
….baremetal Using openshift/api@6a276bd (config/v1/types_infrastructure: Add BareMetal status for BareMetal platform, 2019-06-11, openshift/api#348) so static pods can use the API, DNS, and Ingress VIPs in their configuration.
russellb
added a commit
to russellb/api
that referenced
this pull request
Sep 25, 2019
A recent PR (openshift#348) added the BareMetalPlatformStatus. Add a reference to a document that helps explain the networking architecture for the "baremetal" platform and how these IP addresses are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a BareMetal-specifc status field, akin to AWS status.